Version 2.5.0 #3840
Merged
Version 2.5.0 #3840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add chartjs-plugin-draggable to the list of plugins, update existing ones recently renamed and re-order the list by names.
… added inside the layout system rather than in each axis.
) When datasets.data contains a null value, the label displays incorrect value. code additions: - unit tests for truthy label values (when data is null) - checks to ensure handling of null value in getLabelByIndex method added mock data sets from issue #3528 example expect the return value from getLabelForIndex method to be valid (truthy) added check for null of first data value in getLabelForIndex fixed indentation and null comparison operator in code fixed mistake in definition of firstData variable changed testing for data on index 0 to using index variable changed firstData to use value instead condense the statments to use value variable
…e default padding was changed from 0 to 10. This change caused all of the test changes since the width of a vertical scale was lowered by 10px
…ce the size to change
Clean up radial linear scale. It now supports multiple lines for point labels. Fixes #3225
…exact same x pixel value
added helper method to adjust the index pass in chartConfig rather than access within method, make it easier to test added semi-colon at the end of helper method added test for adjustIndex helper method fixed lint issues added integration test for the interaction of trigger an event over the bar . . moved adjustIndex into element helper removed method from helper and adjusted method in core.interaction added test for the element adjustIndex helper added a skipIndexAdjustment method to handle when to skip the adjustment along with test cases fixed lint issues removed the test for the helper method
Prevent the resize method from notifying plugins if it is a silent resize. A silent resize occurs during startup and we do not want plugins to do anything here because the chart is not set up.
…rst width and last width, the fact that arrays of text are present must be considered. In addition to fixing this, I did some general code cleanup in the fit and calculateLabelRotation methods.
for Bar and horizontalBar type, include stacked scale. issue #3589
Pass the hover event to the onHover event handler
This makes the behavior of the `onHover` handler consistent with the `onClick` handler:
```
function(event, activeElements) {
var chartInstance = this;
}
```
Move base platform definition and logic in src/platform/platform.js and simplify the browser -> Chart.js event mapping by listing only different naming then fallback to the native type. Replace `createEvent` by `add/removeEventListener` methods which dispatch Chart.js IEvent objects instead of native events. Move `add/removeResizeListener` implementation into the DOM platform which is now accessible via `platform.add/removeEventListener(chart, 'resize', listener)`. Finally, remove `bindEvent` and `unbindEvent` from the helpers since the implementation is specific to the chart controller (and should be private).
Instead of cloning `me.scaleSizeInUnits` moments and probably throwing the vast majority away, only clone what we need.
vue-chartjs is a wrapper written in vue for chartjs.
Make all `before` hooks cancellable (except `beforeInit`), meaning that if any plugin return explicitly `false`, the current action is not performed. Ensure that `init` hooks are called before `update` hooks and add associated calling order unit tests. Deprecate `Chart.PluginBase` in favor of `IPlugin` (no more an inheritable class) and document plugin hooks (also rename `extension` by `hook`).
simonbrunel
requested review from
fulldecent,
nnnick,
derekperkins,
tannerlinsley,
jakesylvestre,
etimberg and
panzarino
|
I have bumped the version number and updated the release notes. If someone could give them a read that'd be great |
etimberg
approved these changes
Jan 28, 2017
This was referenced Jan 28, 2017
Closed
Closed
panzarino
approved these changes
Jan 29, 2017
nnnick
approved these changes
Feb 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Milestone: 2.5.0
Merged PRs: 50
Checklist:
See the release process for details.
cc @chartjs/maintainers