[BUG] Wrong category size of Bar with min ,max options.

[KoyoSE]

Hi! thank you for provide excellent chart library.
I would like to report some issue.

Current Behavior

With min (or max) option, Category size probably calculated from the total number of labels, not the number of labels displayed.
Then, the size of bar will be smaller and shift ,even though categoryPercentage and barPercentage is 1.
(also Issues #3506 plugin added)

Steps to Reproduce (for bugs)

jsfiddle

1. Chart type is "bar"
2. Set min or max, both also.
3. When executed, the bar position will be smaller and shift left. (You can see easily when categoryPercentage and barPercentage is 1 )
4. line is work.

Environment

Chart.js version : 2.4.0
Browser name and version : Microsoft Edge 38.14393.0.0
Link to my project : https://jsfiddle.net/d29yoL8u/5
Added Issues #3506 duplicate of #3491 and #2870

[Jareechang]

@etimberg, I can fix this one.

I have a question in regards to ticks.min option, in the documentation it only shows to allow Number. Will we be changing that to allow string datatypes (ex. 'March') ?

[etimberg]

@Jareechang feel free to work on this 😄 Please include test(s) with your fix.

I think ticks.min can be 'March' for the category axis (the one in question here)

[Jareechang]

ok, sounds good! i'll do that 👍

[KoyoSE]

Probably, I think this problem can be solved with this correction.

Possible Solution

Delete the following two codes.

https://github.com/chartjs/Chart.js/blob/master/src/controllers/controller.bar.js#L142-L145

https://github.com/chartjs/Chart.js/blob/master/src/controllers/controller.bar.js#L469-L472

With this fix, it becomes as follows.

jsfiddle

Environment

Chart.js version : 2.4.0
Browser name and version : Microsoft Edge 38.14393.0.0
Link to my project : https://jsfiddle.net/2eq6jxL7/

(I have poor English. so I am sorry if I am rude.)

[etimberg]

@KoyoSE that's a great fix. Could you PR it and add some tests?

[Jareechang]

nice solution @KoyoSE.

I was playing around with the code as well. I came up with this solution code section, we can just add if min or max defined then it'll center the bars. You can maybe try this one if it starts breaking the api.

Another issue

I found another bug while playing with the jsfiddle. The tooltip label is incorrect when min is defined.

Should I open another issue for this ?

[etimberg]

@Jareechang please open another issue for the tooltip issue

[KoyoSE]

Hi @etimberg
I will try adding PR and Test. However, I am still a beginner in JavaScript development. And I recently started using Github. Please give me some time. :)

Hi @Jareechang
Oh I also checked the code section.
but.If min or max defined in that section,
Probably it have to write processing to recalculate the mistaken fullBarWidth in getRuler function.