Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip label is incorrect on Bar chart when min is defined #3618

Closed
Jareechang opened this issue Nov 17, 2016 · 4 comments
Closed

Tooltip label is incorrect on Bar chart when min is defined #3618

Jareechang opened this issue Nov 17, 2016 · 4 comments
Assignees

Comments

@Jareechang
Copy link
Contributor

Expected Behavior

When min is defined, the first tooltip label should display the label at the minimum.

ex. when min is set to 'March', the tooltip should show 'March' as the label.

Current Behavior

currently, it displays data label two indexes down.

ex. when min is set to 'March', it displays 'May'.

Possible Solution

It seems the API slices the datasets into a subset when min or max is defined. Possible solution is to map the index of the parseVisibleItems method.

Steps to Reproduce (for bugs)

  1. Chart type 'bar'
  2. Set min on the chart
  3. Hover over the first bar

Environment

@Jareechang
Copy link
Contributor Author

I am currently working on this one, @etimberg feel free to assign this to me.

@etimberg
Copy link
Member

ok, sounds good @Jareechang

@KoyoSE
Copy link
Contributor

KoyoSE commented Nov 29, 2016

#3620 and #3649 have fixed the same problem.
I tried the test below.

Build from the current latest code

https://jsfiddle.net/T_SAiTO/jw29rrnq/
Tool tip label of bar chart : NG
Tool tip label of horizontal bar chart : OK

Invalidated the change of #3620 from the above build.(only#3649)

https://jsfiddle.net/T_SAiTO/vogqedw1/
Tool tip label of bar chart : OK
Tool tip label of horizontal bar chart : OK

Invalidated the change of #3649 from the above build.(only#3620)

https://jsfiddle.net/T_SAiTO/mnL7wmfj/
Tool tip label of bar chart : OK
Tool tip label of horizontal bar chart : NG

Thank you for your consideration.

@etimberg
Copy link
Member

Sounds like we need to revert the second change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants