Modify `bezier-vscode` metadata for publish #2153

yangwooseong · 2024-04-11T05:07:01Z

Self Checklist

I wrote a PR title in English and added an appropriate label to the PR.
I wrote the commit message in English and to follow the Conventional Commits specification.
I added the changeset about the changes that needed to be released. (or didn't have to)
I wrote or updated documentation related to the changes. (or didn't have to)
I wrote or updated tests related to the changes. (or didn't have to)
I tested the changes in various browsers. (or didn't have to)
- Windows: Chrome, Edge, (Optional) Firefox
- macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Implement bezier-vscode package #2091

Summary

extension 의 icon, publisherName, publisher 등 메타 데이터를 수정하고 배포합니다.

Details

테스트 해봤을 때 scss, ts 파일에서 동작을 확인했습니다. 다만 tsx 파일에서는 동작하지 않네요. client.ts 에서 language: typescript, pattern: '**/*' 를 주고 테스트 했을 때도 안되서 이유는 나중에 찾아봐야할 것 같습니다.
배포할 때는 bezier-vscode/ 밑에서 vsce package 명령어로 VSIX 파일을 만들고 수동으로 업로드했습니다.
이전에 용량이 크다고 에러가 났던 것은 아마 extension 을 만들 때 상위 디렉토리까지 바라봐서 그런 것 같습니다. .vscodeignore 에 상위 디렉토리를 추가하니 번들러를 쓰지 않아도 해결되었습니다.
배포된 링크: https://marketplace.visualstudio.com/items?itemName=ChannelCorp.bezier-vscode
extension 에 verified domain 로 https://channel.io 을 넣을 때 에러가 떠서 이슈에 문의중입니다. (#)

Breaking change? (Yes/No)

No

References

https://code.visualstudio.com/api/working-with-extensions/publishing-extension

changeset-bot · 2024-04-11T05:07:05Z

🦋 Changeset detected

Latest commit: deaa865

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
bezier-vscode	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov · 2024-04-11T05:11:08Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.63%. Comparing base (5fb439b) to head (56b3056).

❗ Current head 56b3056 differs from pull request most recent head deaa865. Consider uploading reports for the commit deaa865 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2153   +/-   ##
=======================================
  Coverage   86.62%   86.63%           
=======================================
  Files         126      126           
  Lines        2655     2656    +1     
  Branches      777      791   +14     
=======================================
+ Hits         2300     2301    +1     
  Misses        350      350           
  Partials        5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yangwooseong · 2024-04-11T05:11:41Z

packages/bezier-vscode/package.json

-  "author": "Channel Corp.",
-  "publisher": "Channel Corp.",
+  "homepage": "https://github.com/channel-io/bezier-react/blob/main/packages/bezier-vscode/README.md",
+  "author": "Channel Corp",


author 에는 . 를 넣을 수 없고 publisher 에는 alphanumeric 만 허용합니다.

vsce package 커맨드를 실행하면 vscode:prepublish 가 먼저 실행됩니다.

sungik-choi

extension 에 verified domain 로 https://channel.io/ 을 넣을 때 에러가 떠서 이슈에 문의중입니다. (microsoft/vsmarketplace#795 (comment))

뒤에 /en path를 넣었을 때는 어떤가요? 리다이렉션 로직이 연관있을 거 같아서요

channeltalk-exp · 2024-04-11T08:16:13Z

https://desk.exp.channel.io/#/channels/1/team_chats/groups/14228/66179c4cb62055a9c2d2

sungik-choi

배포할 때는 bezier-vscode/ 밑에서 vsce package 명령어로 VSIX 파일을 만들고 수동으로 업로드했습니다.

나중에 changeset이랑 묶어서 vscode 버저닝이 있다면 CI에서 vsce publish 실행시켜주는게 가장 좋을 거 같네요

sungik-choi · 2024-04-11T08:22:49Z

packages/bezier-vscode/package.json

-  "name": "@channel.io/bezier-vscode",
-  "version": "0.1.0",
+  "name": "bezier-vscode",
+  "version": "0.1.1",


초기버전은 0.1.0 으로 배포했으면 좋았을 텐데 아쉽네요..! 패키지 이름이 바뀌어서 버전 롤백해도 괜찮았을 거 같아요

extension 을 unpublish 하고 다시 만들어서 0.1.0 으로 맞추면 될 것 같습니다

그런데 다시 보니 bezier-vscode package 가 npm 배포가 안된 상태군요(#).. 혹시 왜 안되는지 아시나요? 다시 버전 0.0.0 으로 하고 changeset minor bump 해야할 것 같네요

package.json의 private 필드를 true로 둬서 그렇습니다. npm 레지스트리에 배포할 필요가 없는 패키지여서요..!

말씀주신대로 하면 될 거 같습니다. CHANGELOG.md 파일도 제거하거나 해서 초기화해야할 거 같네요.

이 pr 이 머지되고 changeset pr 까지 머지되면 이번 pr 만 changelog 에 뜨게 되니 나중에 changelog 를 직접 수정을 해서 처음 pr(https://github.com/channel-io/bezier-react/pull/2091)을 추가해야할 것 같네요. extension 배포는 changeset pr까지 머지된 이후에 다시하겠습니다

yangwooseong · 2024-04-11T08:27:40Z

extension 에 verified domain 로 https://channel.io/ 을 넣을 때 에러가 떠서 이슈에 문의중입니다. (microsoft/vsmarketplace#795 (comment))

뒤에 /en path를 넣었을 때는 어떤가요? 리다이렉션 로직이 연관있을 거 같아서요

테스트해봤을 때 안되었습니다

sungik-choi · 2024-04-11T08:32:19Z

Eligible domains
Eligible domains meet the following criteria:

You must be able to manage the DNS configuration settings and add a TXT record.

It is not a subdomain ({subdomain}.github.io, {subdomain}.contoso.com, or similar).

It must use an HTTPS protocol.

It must be able to respond with an HTTP 200 status to a HEAD request.

라고 하네요. 홈페이지에서 200을 내려주도록 해야할 듯..?

yangwooseong · 2024-04-11T08:40:42Z

Eligible domains
Eligible domains meet the following criteria:

You must be able to manage the DNS configuration settings and add a TXT record.

It is not a subdomain ({subdomain}.github.io, {subdomain}.contoso.com, or similar).

It must use an HTTPS protocol.

It must be able to respond with an HTTP 200 status to a HEAD request.

라고 하네요. 홈페이지에서 200을 내려주도록 해야할 듯..?

클라이언트 위치에 따라서 리다이렉션을 거는 것으로 알고있어서 이것을 없앨 수 있을지 모르겠네요. 한 번 여쭤볼게요

sungik-choi · 2024-04-12T02:43:24Z

.changeset/shiny-rabbits-fly.md

+"bezier-vscode": minor
+---
+
+Modify `bezier-vscode` package.json for displayName and icon


초기 릴리즈라는 정보가 담기도록 변경되면 좋을 거 같아요. 어차피 첫번째 버전으로 퍼블리시될거라 무엇이 변경되었다가 changelog에선 큰 의미가 없을 거 같아요.

@sungik-choi

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. - Fixes an issue where injecting `className` into `FormLabel`, `FormHelperText` inside a `FormControl` does not apply styles correctly. ([channel-io#2156](channel-io#2156)) by @sungik-choi - Updated dependencies - @channel.io/[email protected] - Add "color" prefix to alpha color tokens and fix misnaming of alpha font/typography tokens. ([channel-io#2152](channel-io#2152)) by @sungik-choi - Updated dependencies - @channel.io/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

- add icon - modify publisher and author name valid

- `vsce package` command will include parent directory and throw error because of massive volume

@yangwooseong

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Minor Changes - Set up information about the package for initial publishing ([#2153](#2153)) by @yangwooseong Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

## Self Checklist - [x] I wrote a PR title in **English** and added an appropriate **label** to the PR. - [x] I wrote the commit message in **English** and to follow [**the Conventional Commits specification**](https://www.conventionalcommits.org/en/v1.0.0/). - [x] I [added the **changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md) about the changes that needed to be released. (or didn't have to) - [x] I wrote or updated **documentation** related to the changes. (or didn't have to) - [x] I wrote or updated **tests** related to the changes. (or didn't have to) - [x] I tested the changes in various browsers. (or didn't have to) - Windows: Chrome, Edge, (Optional) Firefox - macOS: Chrome, Edge, Safari, (Optional) Firefox ## Related Issue   - None ## Summary  - #2153 에서 버전이 롤백되었기 때문에 #2091 이 changelog 에 들어가있지 않습니다. 이것을 직접 추가합니다. ## Details  - 생략 ### Breaking change? (Yes/No)  - No ## References  - #2153 (comment)

yangwooseong added the bezier-vscode Issue or PR related to bezier-vscode label Apr 11, 2024

yangwooseong self-assigned this Apr 11, 2024

yangwooseong requested a review from sungik-choi as a code owner April 11, 2024 05:07

yangwooseong commented Apr 11, 2024

View reviewed changes

yangwooseong changed the title ~~Feat/modify vscode meta data~~ Modify vscode metadata for publish Apr 11, 2024

yangwooseong changed the title ~~Modify vscode metadata for publish~~ Modify bezier-vscode metadata for publish Apr 11, 2024

channel-io deleted a comment from channeltalk-exp bot Apr 11, 2024

sungik-choi reviewed Apr 11, 2024

View reviewed changes

yangwooseong requested a review from sungik-choi April 12, 2024 01:36

sungik-choi reviewed Apr 12, 2024

View reviewed changes

sungik-choi approved these changes Apr 12, 2024

View reviewed changes

yangwooseong force-pushed the feat/modify-vscode-meta-data branch from 0b68cb9 to 588800f Compare April 12, 2024 02:52

github-actions bot and others added 9 commits April 12, 2024 11:53

feat(vscode): modify package.json

71b8c77

- add icon - modify publisher and author name valid

feat(vscode): add vscodeignore

8af626c

- `vsce package` command will include parent directory and throw error because of massive volume

chore(changeset): add

9c01f5a

chore(vscode): end of line

6ecb9a9

feat(vscode): change version to 0.0.0

111fc33

chore(changeset): change to minor bump

5787d6a

chore(vscode): rm changelog

5c24e81

chore(changeset): add

deaa865

yangwooseong force-pushed the feat/modify-vscode-meta-data branch from 588800f to deaa865 Compare April 12, 2024 02:53

yangwooseong merged commit aed8dbd into channel-io:main Apr 12, 2024
7 checks passed

yangwooseong deleted the feat/modify-vscode-meta-data branch April 12, 2024 02:56

github-actions bot mentioned this pull request Apr 12, 2024

ci(changesets): version packages #2157

Merged

yangwooseong mentioned this pull request Apr 12, 2024

Add first commit of bezier-vscode to changelog.md #2158

Merged

6 tasks

yangwooseong mentioned this pull request Nov 7, 2024

Enhance bezier-vscode pacakge #2485

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modify `bezier-vscode` metadata for publish #2153

Modify `bezier-vscode` metadata for publish #2153

yangwooseong commented Apr 11, 2024 •

edited

Loading

changeset-bot bot commented Apr 11, 2024 •

edited

Loading

codecov bot commented Apr 11, 2024 •

edited

Loading

yangwooseong Apr 11, 2024

sungik-choi left a comment •

edited

Loading

channeltalk-exp bot commented Apr 11, 2024

sungik-choi left a comment

sungik-choi Apr 11, 2024

yangwooseong Apr 11, 2024

yangwooseong Apr 11, 2024 •

edited

Loading

sungik-choi Apr 11, 2024

yangwooseong Apr 11, 2024 •

edited

Loading

yangwooseong commented Apr 11, 2024

sungik-choi commented Apr 11, 2024

yangwooseong commented Apr 11, 2024

sungik-choi Apr 12, 2024

Modify bezier-vscode metadata for publish #2153

Modify bezier-vscode metadata for publish #2153

Conversation

yangwooseong commented Apr 11, 2024 • edited Loading

Self Checklist

Related Issue

Summary

Details

Breaking change? (Yes/No)

References

changeset-bot bot commented Apr 11, 2024 • edited Loading

🦋 Changeset detected

codecov bot commented Apr 11, 2024 • edited Loading

Codecov Report

yangwooseong Apr 11, 2024

Choose a reason for hiding this comment

sungik-choi left a comment • edited Loading

Choose a reason for hiding this comment

channeltalk-exp bot commented Apr 11, 2024

sungik-choi left a comment

Choose a reason for hiding this comment

sungik-choi Apr 11, 2024

Choose a reason for hiding this comment

yangwooseong Apr 11, 2024

Choose a reason for hiding this comment

yangwooseong Apr 11, 2024 • edited Loading

Choose a reason for hiding this comment

sungik-choi Apr 11, 2024

Choose a reason for hiding this comment

yangwooseong Apr 11, 2024 • edited Loading

Choose a reason for hiding this comment

yangwooseong commented Apr 11, 2024

sungik-choi commented Apr 11, 2024

yangwooseong commented Apr 11, 2024

sungik-choi Apr 12, 2024

Choose a reason for hiding this comment

Modify `bezier-vscode` metadata for publish #2153

Modify `bezier-vscode` metadata for publish #2153

yangwooseong commented Apr 11, 2024 •

edited

Loading

changeset-bot bot commented Apr 11, 2024 •

edited

Loading

codecov bot commented Apr 11, 2024 •

edited

Loading

sungik-choi left a comment •

edited

Loading

yangwooseong Apr 11, 2024 •

edited

Loading

yangwooseong Apr 11, 2024 •

edited

Loading