Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "color" prefix to color tokens and fix misnaming of typography tokens #2152

Merged
merged 11 commits into from
Apr 11, 2024

Conversation

sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Apr 9, 2024

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Summary

Add "color" prefix to color tokens and fix misnaming of typography tokens

Details

  • 논의된 구조에 맞게 색상 토큰 앞에 "color" prefix를 추가합니다.
  • font, typography 토큰의 위계가 잘못되어 몇몇 토큰의 이름에 "font", "typography" prefix가 없던 걸 수정합니다.
  • style: prettier format

Breaking change? (Yes/No)

No

References

Sorry, something went wrong.

@sungik-choi sungik-choi added the bezier-tokens Issue or PR related to bezier-tokens label Apr 9, 2024
@sungik-choi sungik-choi self-assigned this Apr 9, 2024
Copy link

changeset-bot bot commented Apr 9, 2024

🦋 Changeset detected

Latest commit: f00a29c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@channel.io/bezier-tokens Patch
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sungik-choi sungik-choi force-pushed the fix/v2-tokens branch 2 times, most recently from 4ff6701 to 40d799a Compare April 9, 2024 06:38
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Chromatic Report

🚀 Congratulations! Your build was successful!

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.63%. Comparing base (d0cedaf) to head (7ae5785).

❗ Current head 7ae5785 differs from pull request most recent head f00a29c. Consider uploading reports for the commit f00a29c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2152   +/-   ##
=======================================
  Coverage   86.63%   86.63%           
=======================================
  Files         126      126           
  Lines        2656     2656           
  Branches      787      791    +4     
=======================================
  Hits         2301     2301           
  Misses        326      326           
  Partials       29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@channel-io channel-io deleted a comment from channeltalk-exp bot Apr 11, 2024
@sungik-choi
Copy link
Contributor Author

sungik-choi commented Apr 11, 2024

@yangwooseong #2138 에서 잘못 제거되었던 bg/darkest 토큰들을 다시 추가했습니다. (fg/darkest 만 제거되어야 함)

@sungik-choi sungik-choi merged commit 15da8c2 into channel-io:main Apr 11, 2024
8 checks passed
@sungik-choi sungik-choi deleted the fix/v2-tokens branch April 11, 2024 10:27
sungik-choi pushed a commit that referenced this pull request Apr 11, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @channel.io/[email protected]

### Patch Changes

- Fixes an issue where injecting `className` into `FormLabel`,
`FormHelperText` inside a `FormControl` does not apply styles correctly.
([#2156](#2156)) by
@sungik-choi

-   Updated dependencies
    -   @channel.io/[email protected]

## @channel.io/[email protected]

### Patch Changes

- Add "color" prefix to alpha color tokens and fix misnaming of alpha
font/typography tokens.
([#2152](#2152)) by
@sungik-choi

## [email protected]

### Patch Changes

-   Updated dependencies
    -   @channel.io/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@channel-io channel-io deleted a comment from channeltalk-exp bot Apr 12, 2024
yangwooseong pushed a commit to yangwooseong/bezier-react that referenced this pull request Apr 12, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.

- Fixes an issue where injecting `className` into `FormLabel`,
`FormHelperText` inside a `FormControl` does not apply styles correctly.
([channel-io#2156](channel-io#2156)) by
@sungik-choi

-   Updated dependencies
    -   @channel.io/[email protected]

- Add "color" prefix to alpha color tokens and fix misnaming of alpha
font/typography tokens.
([channel-io#2152](channel-io#2152)) by
@sungik-choi

-   Updated dependencies
    -   @channel.io/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yangwooseong pushed a commit to yangwooseong/bezier-react that referenced this pull request Apr 12, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.

- Fixes an issue where injecting `className` into `FormLabel`,
`FormHelperText` inside a `FormControl` does not apply styles correctly.
([channel-io#2156](channel-io#2156)) by
@sungik-choi

-   Updated dependencies
    -   @channel.io/[email protected]

- Add "color" prefix to alpha color tokens and fix misnaming of alpha
font/typography tokens.
([channel-io#2152](channel-io#2152)) by
@sungik-choi

-   Updated dependencies
    -   @channel.io/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bezier-tokens Issue or PR related to bezier-tokens
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants