Skip to content

Commit

Permalink
Modify bezier-vscode metadata for publish (#2153)
Browse files Browse the repository at this point in the history
<!--
  How to write a good PR title:
- Follow [the Conventional Commits
specification](https://www.conventionalcommits.org/en/v1.0.0/).
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

## Self Checklist

- [x] I wrote a PR title in **English** and added an appropriate
**label** to the PR.
- [x] I wrote the commit message in **English** and to follow [**the
Conventional Commits
specification**](https://www.conventionalcommits.org/en/v1.0.0/).
- [x] I [added the
**changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)
about the changes that needed to be released. (or didn't have to)
- [x] I wrote or updated **documentation** related to the changes. (or
didn't have to)
- [x] I wrote or updated **tests** related to the changes. (or didn't
have to)
- [x] I tested the changes in various browsers. (or didn't have to)
  - Windows: Chrome, Edge, (Optional) Firefox
  - macOS: Chrome, Edge, Safari, (Optional) Firefox

## Related Issue

<!-- Please link to issue if one exists -->

- #2091 

<!-- Fixes #0000 -->

## Summary

<!-- Please brief explanation of the changes made -->

- extension 의 icon, publisherName, publisher 등 메타 데이터를 수정하고 배포합니다. 

## Details

<!-- Please elaborate description of the changes -->

- 테스트 해봤을 때 scss, ts 파일에서 동작을 확인했습니다. 다만 tsx 파일에서는 동작하지 않네요. client.ts
에서 language: typescript, pattern: '**/*' 를 주고 테스트 했을 때도 안되서 이유는 나중에
찾아봐야할 것 같습니다.
- 배포할 때는 bezier-vscode/ 밑에서 vsce package 명령어로 VSIX 파일을 만들고 수동으로 업로드했습니다.
- 이전에 용량이 크다고 에러가 났던 것은 아마 extension 을 만들 때 상위 디렉토리까지 바라봐서 그런 것 같습니다.
.vscodeignore 에 상위 디렉토리를 추가하니 번들러를 쓰지 않아도 해결되었습니다.
- 배포된 링크:
https://marketplace.visualstudio.com/items?itemName=ChannelCorp.bezier-vscode
- extension 에 verified domain 로 https://channel.io 을 넣을 때 에러가 떠서 이슈에
문의중입니다.
([#](microsoft/vsmarketplace#795 (comment)))


### Breaking change? (Yes/No)

<!-- If Yes, please describe the impact and migration path for users -->

- No

## References

<!-- Please list any other resources or points the reviewer should be
aware of -->

-
https://code.visualstudio.com/api/working-with-extensions/publishing-extension

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  • Loading branch information
3 people authored Apr 12, 2024
1 parent 5fb439b commit aed8dbd
Show file tree
Hide file tree
Showing 6 changed files with 43 additions and 31 deletions.
5 changes: 5 additions & 0 deletions .changeset/shiny-rabbits-fly.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"bezier-vscode": minor
---

Set up information about the package for initial publishing
16 changes: 16 additions & 0 deletions packages/bezier-vscode/.vscodeignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
.turbo
.eslintcache
**/tsconfig.json
**/*.map
**/*.ts
*.vsix
CONTRIBUTING.md
scripts
src
rollup.config.js
tsconfig.tsbuildinfo
node_modules

# Ignore parent directories
../bezier-*/**
../../**
13 changes: 0 additions & 13 deletions packages/bezier-vscode/CHANGELOG.md

This file was deleted.

Binary file added packages/bezier-vscode/assets/channel-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
14 changes: 9 additions & 5 deletions packages/bezier-vscode/package.json
Original file line number Diff line number Diff line change
@@ -1,15 +1,18 @@
{
"name": "@channel.io/bezier-vscode",
"version": "0.1.0",
"name": "bezier-vscode",
"version": "0.0.0",
"private": true,
"description": "VS Code extension for Bezier Design System",
"icon": "assets/channel-icon.png",
"repository": {
"type": "git",
"url": "https://github.com/channel-io/bezier-react",
"directory": "packages/bezier-vscode"
},
"author": "Channel Corp.",
"publisher": "Channel Corp.",
"homepage": "https://github.com/channel-io/bezier-react/blob/main/packages/bezier-vscode/README.md",
"author": "Channel Corp",
"publisher": "ChannelCorp",
"displayName": "Bezier for VS Code",
"license": "Apache-2.0",
"keywords": [
"channel",
Expand Down Expand Up @@ -55,7 +58,8 @@
"dev": "tsc -b -w",
"lint": "TIMING=1 eslint --cache .",
"typecheck": "tsc --noEmit",
"clean": "rm -rf dist"
"clean": "rm -rf dist",
"vscode:prepublish": "yarn build"
},
"dependencies": {
"vscode-languageclient": "^9.0.1",
Expand Down
26 changes: 13 additions & 13 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2045,19 +2045,6 @@ __metadata:
languageName: unknown
linkType: soft

"@channel.io/bezier-vscode@workspace:packages/bezier-vscode":
version: 0.0.0-use.local
resolution: "@channel.io/bezier-vscode@workspace:packages/bezier-vscode"
dependencies:
"@channel.io/bezier-tokens": "npm:0.2.1"
"@types/node": "npm:^20.11.20"
"@types/vscode": "npm:^1.64.0"
vscode-languageclient: "npm:^9.0.1"
vscode-languageserver: "npm:^9.0.1"
vscode-languageserver-textdocument: "npm:^1.0.11"
languageName: unknown
linkType: soft

"@channel.io/eslint-config@npm:^2.0.4":
version: 2.0.4
resolution: "@channel.io/eslint-config@npm:2.0.4"
Expand Down Expand Up @@ -8412,6 +8399,19 @@ __metadata:
languageName: unknown
linkType: soft

"bezier-vscode@workspace:packages/bezier-vscode":
version: 0.0.0-use.local
resolution: "bezier-vscode@workspace:packages/bezier-vscode"
dependencies:
"@channel.io/bezier-tokens": "npm:0.2.1"
"@types/node": "npm:^20.11.20"
"@types/vscode": "npm:^1.64.0"
vscode-languageclient: "npm:^9.0.1"
vscode-languageserver: "npm:^9.0.1"
vscode-languageserver-textdocument: "npm:^1.0.11"
languageName: unknown
linkType: soft

"big-integer@npm:^1.6.44":
version: 1.6.52
resolution: "big-integer@npm:1.6.52"
Expand Down

0 comments on commit aed8dbd

Please sign in to comment.