Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github actions to check lesson builds #19

Open
colinsauze opened this issue Jun 28, 2021 · 5 comments
Open

Github actions to check lesson builds #19

colinsauze opened this issue Jun 28, 2021 · 5 comments

Comments

@colinsauze
Copy link
Member

There should be some github actions to check the lesson builds correctly and passes make lesson-check.

Examples on doing this available from: https://github.com/carpentries-incubator/template/tree/gh-pages/.github/workflows

@maxim-belkin
Copy link
Contributor

This lesson doesn't pass the website action check because there is no Gemfile. You can get it from https://github.com/carpentries/styles.

@colinsauze
Copy link
Member Author

Thanks @maxim-belkin but its still failing to run lesson-check, any ideas why?

@vinisalazar
Copy link
Collaborator

This check indicates that lesson-check is passing (albeit with warnings), am I missing anything?

@maxim-belkin
Copy link
Contributor

maxim-belkin commented Jul 7, 2021

Thanks @maxim-belkin but its still failing to run lesson-check, any ideas why?

I do see the reason (explained below) but I'm pretty sure make lesson-check-all should not fail no matter what. I'll fix that (in carpentries/styles).

Explanation: make lesson-check-all currently fails because all lines in 05-dimensionality-reduction.md are empty. If you add even a single dot or an empty HTML comment <!-- --> -- it'll succeed. PR #21 adds some text there, so the check passes there

@colinsauze
Copy link
Member Author

I've just seen that error about dimensonality-reduction missing a blank line too. I was expecting it to appear if you expanded the "Run make lesson-check all" section, but I just see it saying (in red) "Error: ". But when I view the raw logs by pressing the 3 dots at the top of the check screen I can see that error.

colinsauze pushed a commit that referenced this issue Sep 25, 2024
Update 05-clustering.md - fix link for spectral clustering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants