Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to pass lesson check #21

Merged
merged 3 commits into from
Jul 7, 2021
Merged

Fixes to pass lesson check #21

merged 3 commits into from
Jul 7, 2021

Conversation

colinsauze
Copy link
Member

  • Using the latest bin directory and Makefile from the lesson template.
  • Replacing python with language-python in code examples
  • Removing some FIXME statements
  • Renumbering episodes so there aren't two numbered 05
  • Other misc fixes to pass lesson check

@colinsauze colinsauze requested a review from vinisalazar June 28, 2021 18:37
@colinsauze
Copy link
Member Author

I don't understand why this isn't passing the checks. It runs make lesson-check fine on my computer.

Copy link
Collaborator

@vinisalazar vinisalazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big one, but I checked out the branch on my local environment and the lesson seems to be building fine. Looks good to me.

Thank you @colinsauze.

@colinsauze
Copy link
Member Author

Its now telling me all checks have passed, but says its skipping the test lesson template check. I really don't understand why its skipped it and if that means it still isn't working right.

@maxim-belkin
Copy link
Contributor

I really don't understand why its skipped it and if that means it still isn't working right.

it is working as intended. Template check is performed in the carpentries/styles repo only.

@colinsauze colinsauze merged commit 127fd52 into gh-pages Jul 7, 2021
colinsauze pushed a commit that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants