Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding github actions to test lesson builds #20

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Conversation

colinsauze
Copy link
Member

@colinsauze
Copy link
Member Author

I know this fails lesson-check, but many of the problems its having we've fixed in other pull requests.

@colinsauze colinsauze requested a review from vinisalazar June 28, 2021 17:19
Copy link
Collaborator

@vinisalazar vinisalazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, LGTM. Since this doesn't directly affect the content of the lesson, there's no problem in merging with a failed status, but it would be nice to have lesson-check passing when possible.

@colinsauze colinsauze merged commit 2b5a155 into gh-pages Jun 28, 2021
colinsauze pushed a commit that referenced this pull request Sep 25, 2024
Changes made to enable delivery of CeR - ML Carpentries - August 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants