Sync #13
Merged
Sync #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change aims at improving the clarity of the writing prompt that guides people to use the slash inserter
* Add padding support to template parts * linting * Update docs * linting * Try to resolve merge conflicts Try to resolve merge conflicts Remove spacing visualizer which is not working in the site editor * Update index.php
* Components: Fix scroll-lock types * Refactor scroll lock to a simple function component * Add inline documentation * Remove unnecessary null check and update tests * Share previousScrollTop between instances * Move setLocked to module level function * Move comment and fix deps array * Remove ability to pass className
* Fix Empty Block Templates output string
* Use a normal WordPress loop similar to themes * post-content: Run the_post if not in a loop * phpcs fix * Address feedback * early exit earlier * Update packages/block-library/src/post-content/index.php Co-authored-by: Nik Tsekouras <[email protected]> Co-authored-by: Nik Tsekouras <[email protected]>
* added initial-html to test-data.js * Added a test that loads all the blocks within a post. * Updated the ci test runners to run gutenberg-editor-blocks * added a function that scrolls to a specific element and returns it. * updated the test to utilize the scroll and return functionality * utilize a shared initialHtml for both test and initial editor content. * added delay to swipe methods. * Remove unneeded code after merging master * Paste instead of typing when setting HTML content * Paste using keycode on Android * Select html content view only on android * Use iOS 14.0 simulator on server * Print driver data on stop * Enable remaining paragraph tests on iOS * Remove dot at the end of jobURL * Print menuButton * Print error if environment cannot be initialized * Revert "Use iOS 14.0 simulator on server" This reverts commit 85178d1. * Revert "Print driver data on stop" This reverts commit f136234. * Revert "Print menuButton" This reverts commit 9e16a13. * Update server appium version to 1.18 and iOS to 14.0 * Add teardown to paste test * On iOS wait for paste notification to disappear * Double tap instead of long press to paste * Fix lint error * On iOS also long press before pasting * On iOS use click instead of clickBeginningOfElement in paragraph test * Scroll to bottom by adding a paragraph block to the end * Use .type on Android instead of pressing paste keycode * Check last block without scrolling on iOS * Update package-lock.json * added endYCoefficient to increase the swipe distance on Android. * added package-lock.json * Retry one more time getting the last block after a delay on iOS * Temporarily delete cancel workflow (and others) to run native jobs multiple times more quickly in consecutive commits * Run 1 * Run 2 * Run 3 * Run 4 * Run 5 * Run 6 * Run 7 * Run 8 * Revert "Temporarily delete cancel workflow (and others) to run native jobs multiple times more quickly in consecutive commits" This reverts commit fe5a1b1. * Temporarily delete cancel workflow * Run 1 * Run 2 * Run 3 * Run 4 * Run 5 * Run 6 * Run 7 * Run 8 * Temporarily delete non-native workflows * Bump reactivecircus/android-emulator-runner action to v2.15.0 * Run 1 * Run 2 * Run 3 * Run 4 * Run 5 * Run 6 * Run 7 * Run 8 * Run 9 * Run 10 * Run 11 * Run 12 * Run 13 * Run 14 * Run 15 * Run 16 * Revert "Temporarily delete cancel workflow" This reverts commit b31695a. * Revert "Temporarily delete non-native workflows" This reverts commit ff5a3c4. * Rename test file Co-authored-by: Ceyhun Ozugur <[email protected]>
…op bar will close it again (#29759) * Rotate the inserter icon and switch the label when pressed * Use a single label rather than toggling. Include reduce-motion mixin. * Update tests * formatting * Update test snapshots * Update labels * Add old selectors * Add comment Co-authored-by: David Szabo <[email protected]>
This reverts commit 87db183.
* Added a practical example of adding a component to the sidebar. * Apply suggestions from code review I needed to unresolve the comments so I could commit them. In GitHub, it is possible to accept the suggestions and commit them directly from the Files tab in the PR. Co-authored-by: Marcus Kazmierczak <[email protected]>
* Gutenberg Plugin: Remove deprecations planned for 10.3 release * Docs: Add changelog entry
* Widgets Customizer: Enable Legacy Widget block Wires up the Legacy Widget block to the Widgets Customizer. * Widgets Customizer: Remove __unstable_instance in lieu of raw_instance. Removes __unstable_instance from the instance object returned by the Customizer and instead add raw_instance. This property is only added if the widget has declared that it supports raw instances via the show_instance_in_rest flag. * Use themes.php in Legacy Widget iframe * Use destructuring in widgetToBlock
…0365) The `plugins_loaded` filter doesn't work to successfully remove these actions. Relevant comment: #23961 (comment)
Remove documented code using `__experimentalGetSettings` as per https://developer.wordpress.org/block-editor/contributors/develop/coding-guidelines/#experimental-and-unstable-apis
…mensionally (#30014) * Update "close small" icon so that its shape matches the "add" icon dimensionally. * Update test snapshots * Update e2e test snapshots Co-authored-by: David Szabo <[email protected]>
- Favor more concise wording such as "Add caption". - Remove trailing ellipsis. This is meant to work better with the new persistent placeholder text until the user types in RichText.
* Add post format variation to nav link block * post format is a taxonomy * Switch to using custom post type icon for format variation * Override some values for post_format and post_tag * Update test snapshot for fallback variations * Add comment * Use post_format as name and type for variation * Remove post format fallback variation
…kSuggestions in post, site, navigation, widget editor (#29993)
Co-authored-by: Bernie Reiter <[email protected]>
* Release script: Update react-native-editor version to 1.50.0 * Release script: Update with changes from 'npm run core preios' * Gutenberg Plugin: Remove deprecations planned for 10.3 release (#30417) * Gutenberg Plugin: Remove deprecations planned for 10.3 release * Docs: Add changelog entry * Closed changelog for 1.50.0 Co-authored-by: Greg Ziółkowski <[email protected]>
Co-authored-by: Andrew Serong <[email protected]>
- @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected]
* Create new AltTextSettings component With this commit, a new AltTextSettings component has been introduced to replace the current TextControl that exists for entering an image's Alt text. This new component makes use of BottomSheet.SubSheet, so that users are taken to a new subsheet when entering alt text. * Update text colour in footer note in styles.css The current text in the alt text subsheet's footer doesn't meet WordPress' accessibility standards for colour contrast. This commit updates the colour from " $gray-30" to "$gray-text-min" in order to meet those standards. * Increase min-height of altTextEditor This commit increases the min-height of "altTextEditor" so that the editor is a larger height on iOS devices by default. * Update border colours for both light and dark mode This commit updates the component's border colours to match similar separators/borders throughout the app. "light-gray-400" is used for light mode and "gray-70" for dark mode. * Update text colour in dark mode This commit fixes a bug, where text entered in iOS appear black on black (therefore, unreadable) in dark mode. * Update footer note styling in styles.css With this commit, I've tweaked the font size and padding around the "altTextSetting" compont's footer note to more closely match up with the initial design. * Set max height for the editor This commit fixes a bug I spotted while testing, where it's possible to continue hitting "enter" and increasing the size of the editor without limitless, leading to the footer note being dragged off screen. * Increase bottom padding of footer note This commit increase the padding at the bottom of the footer note, in accordance with the design. * Update colour of placeholder text This commit updates the colour of the default placeholder text in the "AltTextSettings" component's TextInput. The purpose of defining this is to fix a bug in iOS, where the placeholder text appeared as black on black in dark mode. * Styling tweaks to footnote and placeholder text Two small changes to the "Alt Text Settings" components are included in this commit. The first increases the padding of the footnote to match the design and the second aligns the placeholder text to the top, which is necessary for Android devices. * Update font-size of footnote Changes the font-size of the footnote from 13px to 12px, based on feedback. * Set defined height for altTextEditor This commit sets a defined height of 80px for the altTextEditor component, in response to feedback and to remove complexity around the box expanding when text is entered. * Update blue colour of link for both light and dark mode The colour of the link is updated for both light and dark mode with this commit, based on feedback received. * Update CHANGELOG.md Update CHANGELOG.md with changes from this commit. * Convert "AltTextSettings" component into more generic "BottomSheetTextControl" component This commit, converts the "AltTextSettings" component into more generic "BottomSheetTextControl" component by removing references to "alt" from main component and passing down props. * Created README.md for BottomSheetTextControl component This commit introduces a README.md for the new BottomSheetTextControl component. * Formatting tweaks for README.md * Formatting tweaks for README.md Fixes some issues with spacing. * retrigger checks * Simplify BottomSheetTextControl This commit seeks to simplify the BottomSheetTextControl component by splitting out two more, smaller components from it: 1. smallFooterMessageControl 2. smallFooterMessageControlLink * retrigger checks * Correct merge conflict * Update "SmallFooterMessageLinkControl" to "FooterMessageLink" This commit updates the name of "SmallFooterMessageLinkControl" to "FooterMessageLink" in order to be clearer and more readable. * Update "SmallFooterMessageLinkControl" to "FooterMessageLink" This commit updates the name of "SmallFooterMessageLinkControl" to "FooterMessageLink" in order to be clearer and more readable. * Delete small-footer-message-control-link.native.js * Remove small-footer-message-control * Update Footer Message Control * Add README to FooterMessageLink component This commit moves FooterMessageLink to a separate folder for the purpose of adding a README * Revert accidental commit This reverts an accidental commit, where I'd made changes in "link-settings/index.native.js" as part of general testing. I also remove "textAlign="left"" from a FooterMessageControl component in this file, as this is now the default.
…aceholder (#30463) * Writing flow: fix horizontal caret placing for empty rich text with placeholder * Prevent placeholder from catching selection (esp in FF) * Scroll into view if needed
* remove scope from query patterns * clone blocks on insertion * properly handle query update and make previews show 1 post per page * fix typos
…30387) * switch to block tab on block select * add e2e tests
* Add option to make PostDate a link * update fixture
* Some improvements to NPM caching within GHA workflows. This ensures the version of Node.JS is set up prior to configuring or restoring the cache of NPM modules. * This updates the version of `actions/setup-node` used to the latest, 2.x. * Redo formatting updates.
* docgen: Detect TS index modules * docgen: Handle arrow function annotations * Refactor restParam to explicitly only handle one rest param * Use more descriptive and singular names for target file cases * Fix constructor missing return type * Simplify rest param handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.