-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icons: Update "close small" icon so that its shape matches the "add" icon dimensionally #30014
Conversation
Size Change: +11.6 kB (+1%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Details matter. Nice.
I'm a bit curious why the filesize diff is so much bigger — did the new SVG add a bunch of points? 12 should be enough if I'm counting correctly?
But that's a small thing. Ship it.
@jasmussen I think it's because the old version is two strokes (4 points) whereas the new one is an outlined shape (12 points). Using an outlined shape means the "stroke" will scale along with the size of the icon instead of remaining consistent: I'm not exactly sure which is the preference here. Different icons behave differently in this respect currently. |
Oh definitely should be an outline shape! Edit: that was unclear. It should definitely be an outlined, i.e. solid, shape. So your change is preferable. |
☝️ Edited, because my previous comment was unclear :D |
You need to run |
Looks like you need to run |
Tried that, no files were updated 🙈 |
Before:
After:
This helps create harmony across the set, particularly is #29759 lands.