Block Library - Query: Use a WordPress loop for the query block #30405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristath
added
[Block] Post Content
|
Size Change: +977 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Mar 31, 2021
There was a problem hiding this comment.
Thanks for working on this Ari! In general I feel the direction is good but I would feel a lot more confident with testing the site editor as well. Do you think we should wait for woo 5.2 as is meant to include the FSE wsod fix ?
I tested locally by reverting this commit https://github.com/woocommerce/woocommerce-gutenberg-products-block/pull/3219/files in WooCommerce (that is the one referenced in the linked comment) and didn't see anything break... Reverting the commit does fix the WSOD, and there doesn't seem to be anything breaking in the site-editor, but I can't really test previewing a single-post there. I don't think it's even possible right now, unless I'm missing an obvious method? 🤔 Regardless of that however, the fix is for more than just WooCommerce, it should also fix any plugin using a custom template for a custom post-type (like events, products, jobs listings etc). |
ntsekouras
reviewed
Mar 31, 2021
ntsekouras
reviewed
Mar 31, 2021
Co-authored-by: Nik Tsekouras <[email protected]>
ntsekouras
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
I tested locally by reverting this commit https://github.com/woocommerce/woocommerce-gutenberg-products-block/pull/3219/files in WooCommerce
I tested as well a bit there, as actually the site-editor is still there - but is hiding with a display:none :)
In general nothing broke to my testing either and the changes are reasonable. My main concerned was this and was answered.
Regardless of that however, the fix is for more than just WooCommerce,
I know, it was just easier for me to test with :)
I think we can move on with this and keep our eyes open for any regression 😄
Thanks for your work Ari!
|
Thanks for the fix! Just popping in here to let you know this fixed the rendering of single product pages for Woo. |
|
Perfect, thanks for the update @nerrad! |
|
I'm not sure if this is related to this PR, but posting here. When I go to edit the single post template in the site editor, I see this (referring to the "No post found" for various blocks on the page):
|
|
I reverted the commit locally and it's the same without it :) |
|
Cool! I'm misunderstanding expectations here. It's all good 😄 |
gziolo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the implementation of the query-loop block a bit.
Prior to this PR, we were running
get_posts()to get the list of posts, and then ran these through aforeachloop.With this PR, we are running a
WP_Queryand then the results of that go through a standard Loop (see WP loop docs for details).The benefit of this tweak is that now WordPress functions and hooks work as expected, without breaking backwards-compatibility.
WooCommerce compatibility
This is not limited to WooCommerce, it applies to any and all plugins hooking in WP to change the way their templates are displayed. Until they transition to an FSE structure they need to remain functional, and with this PR they work.
How has this been tested?
Tested with an FSE theme:
In all cases the frontend was showing what was expected.
Checklist:
*.native.jsfiles for terms that need renaming or removal).cc @ntsekouras