We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Description
After Investigate existing solutions to speed up Local Hub rewrite task, we decided to give up with Local Hub rewrite. Instead, we will implement our delegated storage in separate Go service and use gRPC in Local Hub to delegate values resolution.
values
The initial protobufs were defined in #644
Steps
Q: what is the contract here? should delegated storage always return context, even if not modified or not?
createTypeInstance
createTypeInstances
capact/hub-js/graphql/local/schema.graphql
Lines 386 to 401 in f6f487e
value
Additional
Update Local Hub GraphQL mutations and queries with backend.context property. It should be of type Any!. For example:
backend.context
Any!
mutation CreateTypeInstances { createTypeInstances( in: { typeInstances: [ { alias: "helm-release" typeRef: { path: "cap.type.helm.chart.release", revision: "0.1.0" } value: { key: "test" # same as it was } backend: { id: "123" # it's like that already. context: { # new property of type `Any!` name: "release-name", namespace: "release-namespace", } } } ] } ) { id alias } }
query GetTypeInstance($typeInstanceID: ID!) { typeInstance(id: $typeInstanceID) { id typeRef { path revision } backend { # current backend entry id abstract } lockedBy latestResourceVersion { resourceVersion createdBy metadata { attributes { path revision } } spec { value } backend { context { # new property of type `Any!` name namespace } } } } }
Validate Storage TypeInstance value - Stretch, if not possible, extract to dedicated task. - extracted to: Add Storage TypeInstance related validation #656
Integration tests are out of scope
See epic #604 for reason and use cases.
The text was updated successfully, but these errors were encountered:
neo4j/graphql
PRs:
Sorry, something went wrong.
update
mszostok
No branches or pull requests
Description
After Investigate existing solutions to speed up Local Hub rewrite task, we decided to give up with Local Hub rewrite. Instead, we will implement our delegated storage in separate Go service and use gRPC in Local Hub to delegate
values
resolution.The initial protobufs were defined in #644
Steps
createTypeInstance
mutation to use thecreateTypeInstances
. If not possible, remove it and adjust all its usage.capact/hub-js/graphql/local/schema.graphql
Lines 386 to 401 in f6f487e
value
only for built-in storage backendsAdditional
Update Local Hub GraphQL mutations and queries with
backend.context
property. It should be of typeAny!
. For example:Validate Storage TypeInstance value - Stretch, if not possible, extract to dedicated task. - extracted to: Add Storage TypeInstance related validation #656
Integration tests are out of scope
Related issues
See epic #604 for reason and use cases.
The text was updated successfully, but these errors were encountered: