-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Secret storage backend as gRPC server #644
Conversation
b5f2b6c
to
795dd28
Compare
8af5f25
to
2c71d10
Compare
2c71d10
to
6474795
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really enjoyed reviewing your PR, really nice work 👍
9b14085
to
397b49f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,315 @@ | |||
package secretstoragebackend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably even earlier, as using the dotenv
will be useful in e2e tests, so we will need to add some padding to other task to figure this out or you can create a follow-up task to enable the Secret Store storage "consumption" by Local Hub.
Integration tests failed during Capact iunstallation, but the previous run was successful (https://github.com/capactio/capact/actions/runs/1900095690) - and also this PR doesn't change anything related to integration tests, so I'm merging this without retry. |
Description
Changes proposed in this pull request:
dotenv
provider. Thevault
provider needs to be testedTODO
dotenv
providers tellerops/teller#60)Notes
Lint failing because of timeout. Don't worry about it - The job will be green after review 🙂
Testing
To regenerate the gRPC code, run:
To run example calls against the gRPC service:
Create AWS security credentials with
SecretsManagerReadWrite
policy.Export environment variables:
Run the server:
Now let's use Go generated gRPC client to to see how the server behaves. Run the example
pkg/hub/api/grpc/storage_backend/example_test.go
.To run it, you can e.g. change the
func ExampleNewStorageBackendClient() {
tofunc TestE2EScenario(t *testing.T) {
and run it as an usual test.Change the line 12 of this test and run it again:
Related issue(s)
Resolves #637