-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor hub-js, add value mirroring for specified backend #652
Refactor hub-js, add value mirroring for specified backend #652
Conversation
18c7b51
to
644a294
Compare
644a294
to
88d46fe
Compare
b6e6e6d
to
73e315b
Compare
73e315b
to
45c2817
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Good work! I have a few comments regarding app behavior and project structure.
ed5701b
to
92ee949
Compare
3251814
to
ed3b090
Compare
ed3b090
to
d1fcb7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Before merge, please just address one last comment from my side 🙂
3606971
to
f6d5c1e
Compare
Description
Changes proposed in this pull request:
createTypeInstance
and instead delegate it tocreateTypeInstances
mutation. Because of that I had to change the return type fromTypeInstance
to{ id, alias}
backend.context
property. I updated Go Client, GraphQL, Local Hub, examples to use new syntax:Testing
The test that I wrote, proves that it works e2e (Go client -> GraphQL -> Local Hub -> External Storage).
Run neo4j:
Run modified storage server:
Run Local Hub:
Run test:
You should get similar output:
Manually remove
dotenv
storage data:rm -rf /tmp/capact
Modify the relations in test
/pkg/hub/client/local/client_test.go
from:to
Run tests:
You should observe an error in transaction after storing data in external system, but the related data should be automatically deleted in this case, leaving the system in the expected state.
Check that no data is stored:
ls /tmp/capact
Related issue(s)