Add grpc investigation, change proto location, gen TS client, fix typo #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszostok
added
area/hub
mszostok
requested review from
tmitchell,
pkosiec and
mkuziemko
as code owners
mszostok
force-pushed
the
hub-grpc-aware
branch
from
58d3e6a to
4bcf363
Compare
mszostok
force-pushed
the
hub-grpc-aware
branch
from
4bcf363 to
666c4c1
Compare
mszostok
force-pushed
the
hub-grpc-aware
branch
from
666c4c1 to
0b59583
Compare
Co-authored-by: Paweł Kosiec <[email protected]>
This was referenced Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
pkgwhere also the only client and server were generated. Now we also generate client to Local Hub. To follow our approach, the API manifests should be placed in thehub-jsdirectory, same as we have with GraphQL.gen-grpc-resources.shtypeinstanceIdtotypeInstanceIdTesting
Check the gRPC investigation.
Related issue(s)