Clean up sample data #969
Merged
Clean up sample data #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
deployment-dev
angela-tran
previously approved these changes
Sep 28, 2022
|
Rebasing changes to fix conflicts... |
this wasn't being used and adding noise to our PO files and sample migration
more closely resemble production
more closely resemble production
thekaveman
force-pushed
the
chore/sample-data-cleanup
branch
from
d353323 to
de5fcdf
Compare
thekaveman
commented
Sep 28, 2022
| @@ -95,35 +95,19 @@ def load_sample_data(app, *args, **kwargs): | |||
| EligibilityVerifier = app.get_model("core", "EligibilityVerifier") | |||
|
|
|||
| verifier1 = EligibilityVerifier.objects.create( | |||
There was a problem hiding this comment.
c85f4d2 is the critical commit of the PR - I removed the extra sample verifier we had (previously standing in as a placeholder for the DMV), and moved the existing sample OAuth verifier up and renamed it to verifier1.
This had a big impact on the PO files
|
I couldn't get this to run at first... make sure you run |
angela-tran
approved these changes
Sep 28, 2022
3 tasks
thekaveman
added a commit
to cal-itp/eligibility-server
that referenced
this pull request
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up to #958 - we actually don't need some of the sample data anymore. Also make the sample data we do need more closely align with production data for easier testing.
Part of #776