Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: rename content_title to headline #966

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Chore: rename content_title to headline #966

merged 1 commit into from
Sep 29, 2022

Conversation

angela-tran
Copy link
Member

Closes #962

Covers some intent from #776

@angela-tran angela-tran added this to the Courtesy Cards milestone Sep 28, 2022
@angela-tran angela-tran requested a review from a team as a code owner September 28, 2022 15:49
@angela-tran angela-tran self-assigned this Sep 28, 2022
@github-actions github-actions bot added front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework deployment-dev [auto] Changes that will trigger a deploy if merged to dev tests Related to automated testing (unit, UI, integration, etc.) back-end Django views, sessions, middleware, models, migrations etc. and removed deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Sep 28, 2022
@angela-tran angela-tran force-pushed the chore/headline-rename branch 2 times, most recently from ec2ad45 to 08664bf Compare September 28, 2022 19:38
thekaveman
thekaveman previously approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update migrations for this

@thekaveman
Copy link
Member

Might be good to wait for #969

@angela-tran
Copy link
Member Author

Rebased and resolved merge conflicts

thekaveman
thekaveman approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@angela-tran angela-tran merged commit 699bb84 into dev Sep 29, 2022
@angela-tran angela-tran deleted the chore/headline-rename branch September 29, 2022 19:12
@machikoyasuda machikoyasuda mentioned this pull request Sep 29, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machikoyasuda machikoyasuda machikoyasuda approved these changes

@thekaveman thekaveman thekaveman approved these changes

Assignees

@angela-tran angela-tran

Labels
back-end Django views, sessions, middleware, models, migrations etc. front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
Milestone
Courtesy Cards
Development

Successfully merging this pull request may close these issues.

Rename all content_title fields and msgids to headline
3 participants
@angela-tran @thekaveman @machikoyasuda