Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Django .po files #776

Closed
3 tasks done
Tracked by #767
machikoyasuda opened this issue Jul 11, 2022 · 5 comments
Closed
3 tasks done
Tracked by #767

Clean up Django .po files #776

machikoyasuda opened this issue Jul 11, 2022 · 5 comments
Labels
front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework

Comments

@machikoyasuda
Copy link
Member

machikoyasuda commented Jul 11, 2022

The purpose of this ticket is to clean up our naming conventions and names on the msgIDs for the Django .po files.

  • Remove dmv mst
  • Perhaps rename oauth to something more descriptive? Or document what path oauth refers to
  • Come up with a better naming system for the current mst (courtesy card) flow pages
@machikoyasuda machikoyasuda moved this to This Sprint (Month) in Digital Services Jul 11, 2022
@angela-tran angela-tran added the front-end HTML/CSS/JavaScript and Django templates label Jul 11, 2022
@angela-tran angela-tran mentioned this issue Jul 12, 2022
12 tasks
@angela-tran angela-tran self-assigned this Jul 12, 2022
@angela-tran angela-tran moved this from This Sprint (Month) to In Progress in Digital Services Jul 12, 2022
@angela-tran
Copy link
Member

angela-tran commented Jul 12, 2022

I have some additional ideas on cleaning up our process around .po files:

  1. I'd like for us to have a workflow that makes use of Django's makemessages utility. It seems like we lost that when we had to move some msgids to our fixtures since running makemessages would comment out the ones that it can't see in our fixtures. One solution could be to have separate PO files for the fixture msgids and have a script that combines those with the result of makemessages.
  2. Avoid reusing msgids for paragraphs on different pages. Even if the content is the same, we should define a separate msgid/msgstr entry so that reading through template files and .PO files is easier. One example of a confusing re-usage is agency_index.p[3] on the eligibility/start.html template.

@angela-tran
Copy link
Member

angela-tran commented Jul 12, 2022

Notes for myself as I'm reading through the .PO files:

@thekaveman
Copy link
Member

  1. Avoid reusing msgids for paragraphs on different pages. Even if the content is the same, we should define a separate msgid/msgstr entry so that reading through template files and .PO files is easier. One example of a confusing re-usage is agency_index.p[3] on the eligibility/start.html template.

💯

@thekaveman thekaveman added the i18n Copy: Language files or Django i18n framework label Jul 14, 2022
@thekaveman thekaveman moved this from In Progress to Backlog in Digital Services Aug 29, 2022
@machikoyasuda machikoyasuda moved this from Backlog to This Sprint (Month) in Digital Services Sep 22, 2022
@machikoyasuda
Copy link
Member Author

Use mst_cc for new CC copy

@machikoyasuda
Copy link
Member Author

Closing - Addressed in #958 #966 #969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework
Projects
Archived in project
Development

No branches or pull requests

3 participants