-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC83: Add admin call to make virtual study available for all users on their landing pages #10829
Conversation
src/main/java/org/cbioportal/security/VirtualStudyPermissionService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cbioportal/security/VirtualStudyPermissionService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cbioportal/web/PublicVirtualStudiesController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cbioportal/security/VirtualStudyPermissionService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cbioportal/web/PublicVirtualStudiesController.java
Outdated
Show resolved
Hide resolved
Lastly just try to address as much as the sonar cloud issues as possible |
src/main/java/org/cbioportal/service/util/SessionServiceRequestHandler.java
Show resolved
Hide resolved
src/main/java/org/cbioportal/web/PublicVirtualStudiesController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cbioportal/web/PublicVirtualStudiesController.java
Outdated
Show resolved
Hide resolved
@pieterlukasse Please check these extras 162e5a4 |
Looks good. One final question: what guarantees that |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
To prevent missuse of the request to publish virtual study for everyone!
User has to have * username witch is not likely
Co-authored-by: pieterlukasse <[email protected]>
Also get rid of undocumented endpoint
Make sure that we unpublish public virtual study. Fail otherwise.
Quality Gate passedIssues Measures |
Fix # (see https://help.github.com/en/articles/closing-issues-using-keywords)
Describe changes proposed in this pull request:
Frontend cBioPortal/cbioportal-frontend#4923
Checks
Any screenshots or GIFs?
If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek
Notify reviewers
Read our Pull request merging
policy. It can help to figure out who worked on the
file before you. Please use
git blame <filename>
to determine thatand notify them either through slack or by assigning them as a reviewer on the PR