Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC83: Add admin call to make virtual study available for all users on their landing pages #10829

Merged
merged 28 commits into from
Jul 10, 2024

Conversation

forus
Copy link
Contributor

@forus forus commented Jun 13, 2024

Fix # (see https://help.github.com/en/articles/closing-issues-using-keywords)

Describe changes proposed in this pull request:

  • Introduce an admin call, secured by a secret key, to publish virtual studies for all users, making them visible on the landing page.

Frontend cBioPortal/cbioportal-frontend#4923

Checks

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek

Notify reviewers

Read our Pull request merging
policy
. It can help to figure out who worked on the
file before you. Please use git blame <filename> to determine that
and notify them either through slack or by assigning them as a reviewer on the PR

@forus forus requested a review from haynescd June 25, 2024 08:10
@haynescd
Copy link
Collaborator

Lastly just try to address as much as the sonar cloud issues as possible

@forus
Copy link
Contributor Author

forus commented Jun 27, 2024

Lastly just try to address as much as the sonar cloud issues as possible

@haynescd please have another look. The last 2 sonar cloud issues are intended. There is ticket for fixing those #10843

pom.xml Show resolved Hide resolved
@forus
Copy link
Contributor Author

forus commented Jun 28, 2024

@haynescd Please have a look into docs 3ca2a7b

@forus
Copy link
Contributor Author

forus commented Jul 2, 2024

@pieterlukasse Please check these extras 162e5a4

@forus forus requested a review from pieterlukasse July 2, 2024 16:22
@pieterlukasse
Copy link
Member

Looks good. One final question: what guarantees that
test5UnpublishVirtualStudy, test6NoPublicVirtualStudiesAfterRemoval, test7UnpublishedVirtualStudyExists execute in sequence?

@forus
Copy link
Contributor Author

forus commented Jul 3, 2024

Looks good. One final question: what guarantees that test5UnpublishVirtualStudy, test6NoPublicVirtualStudiesAfterRemoval, test7UnpublishedVirtualStudyExists execute in sequence?

@FixMethodOrder(MethodSorters.NAME_ASCENDING) at the top of the test class.

Copy link
Collaborator

@haynescd haynescd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

forus and others added 26 commits July 10, 2024 17:36
To prevent missuse of the request to publish virtual study for everyone!
User has to have * username witch is not likely
Make sure that we unpublish public virtual study. Fail otherwise.
Copy link

sonarcloud bot commented Jul 10, 2024

@forus forus merged commit a4a5942 into master Jul 10, 2024
21 of 22 checks passed
@forus forus deleted the rfc83 branch July 10, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants