Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SessionServiceController to reuse some of the SessionServiceRequestHandler methods. #10876

Open
forus opened this issue Jul 2, 2024 · 4 comments

Comments

@forus
Copy link
Contributor

forus commented Jul 2, 2024

Proposed here:
#10829 (comment)

SessionServiceRequestHandler is an HTTP client that talks to the session service. It has all low-level HTTP code to interact with the session service. SessionServiceController is doing the same now.

We can make SessionServiceController to call SessionServiceRequestHandler instead of composing low-level HTTP calls by itself.
See PublicVirtualStudiesController as an example

@Mehdi-17
Copy link

Mehdi-17 commented Jul 2, 2024

Hello @forus , can I work on this issue if no one else is?

@forus
Copy link
Contributor Author

forus commented Jul 3, 2024

Hello @forus , can I work on this issue if no one else is?

@Mehdi-17 Hello, sure. Please go ahead. Thank you!

@Mehdi-17
Copy link

Mehdi-17 commented Jul 3, 2024

@forus thank you !!

@darkhanzhursin
Copy link

Hi @forus @Mehdi-17 what is the status of this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants