✨ Add PatientIdentifiers URL Parameter #4616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inodb
reviewed
May 9, 2023
There was a problem hiding this comment.
Thanks @haynescd ! This is great!
There is some odd behavior I noticed when you use the filter. It doesn't seem to load all the charts?
It does load all the charts when I access it directly: https://deploy-preview-4616--cbioportalfrontend.netlify.app/study/summary?id=msk_impact_2017
|
@inodb Interesting. This link produces the same outcome (sampleIdentifier Url Parameter). I can look into why all charts are not loaded. |
alisman
reviewed
May 9, 2023
alisman
reviewed
May 9, 2023
alisman
reviewed
May 9, 2023
alisman
reviewed
May 9, 2023
|
Thanks @haynescd ! |
haynescd
force-pushed
the
feature/10081-Support-filter-urls-for-patientIds
branch
2 times, most recently
from
cbb851d to
48d489a
Compare
haynescd
force-pushed
the
feature/10081-Support-filter-urls-for-patientIds
branch
from
48d489a to
1472e6c
Compare
alisman
reviewed
May 10, 2023
alisman
reviewed
May 10, 2023
alisman
reviewed
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal#10081
The Study View Page currently has a way to construct filterJSON URL with sample IDs:
https://cbioportal.org/study/summary?id=msk_impact_2017#filterJson={"sampleIdentifiers":[{"studyId":"msk_impact_2017","sampleId":"P-0000004-T01-IM3"}]}
Update StudyViewPageStore to handle the following URL Parameter
JSON that is now supported within filterJson
{"patientIdentifiers": [{"studyId": "test_studyId", "patientId": "test_patientid"}]}Ex:
https://cbioportal.org/study/summary?id=msk_impact_2017#filterJson={"patientIdentifiers":[{"studyId":"msk_impact_2017","patientId":"P-0000004"}]}