Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support filter urls for patientIds and manage limit #10081

Closed
inodb opened this issue Mar 13, 2023 · 0 comments · Fixed by cBioPortal/cbioportal-frontend#4616
Closed

support filter urls for patientIds and manage limit #10081

inodb opened this issue Mar 13, 2023 · 0 comments · Fixed by cBioPortal/cbioportal-frontend#4616

Comments

@inodb
Copy link
Member

inodb commented Mar 13, 2023

The Study View Page has a way to construct filterJSON URL with sample IDs:

https://cbioportal.org/study/summary?id=msk_impact_2017#filterJson={"sampleIdentifiers":[{"studyId":"msk_impact_2017","sampleId":"P-0000004-T01-IM3"}]}

Can we enable the same for using patientIdentifiers and patientId? So something like:

https://cbioportal.org/study/summary?id=msk_impact_2017#filterJson={"patientIdentifiers":[{"studyId":"msk_impact_2017","patientId":"P-0000004"}]}

There is also a URL parameter limit for this filterJSON that we might run into at some point. Wondering if providing POST as another way of supplying the filter would be good in cases where the filterJSON doesn't cut it

Note to self: please let Shai Ahmed from dataline team know once this is implemented

@inodb inodb changed the title support filter urls for patientIds and manage support filter urls for patientIds and manage limit Mar 13, 2023
@inodb inodb assigned alisman and unassigned dubincorey Mar 23, 2023
@alisman alisman assigned haynescd and unassigned alisman Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants