[PLAT-1678] Change to use new objdump command 2X #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattrali
reviewed
Sep 10, 2018
| @@ -152,7 +152,7 @@ class BugsnagUploadNdkTask extends BugsnagUploadAbstractTask { | |||
| // Call objdump, redirecting output to the output file | |||
| project.logger.info("${getLogPrefix()} Calling objdump process") | |||
|
|
|||
| ProcessBuilder builder = new ProcessBuilder(objDumpPath.toString(), "--disassemble", "--demangle", "--line-numbers", "--section=.text", sharedObject.toString()) | |||
| ProcessBuilder builder = new ProcessBuilder(objDumpPath.toString(), "-W", "-x", "--section=.debug_line", sharedObject.toString()) | |||
There was a problem hiding this comment.
What subset of -W is actually necessary (since it wraps several options)? This file size could be reduced if we know specifically which components are required.
There was a problem hiding this comment.
Good point, I have refined the command to use --dwarf=info --dwarf=rawline. In my example this has reduced the size from 72Mb -> 67Mb
kattrali
approved these changes
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Use faster version of objdump command
Requires https://github.com/bugsnag/bugsnag-event-worker/pull/1061 to parse the new file upload
Review
For the submitter, initial self-review:
For the pull request reviewer(s), this changeset has been reviewed for: