Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-1678] Change to use new objdump command 2X #130

Merged
merged 3 commits into from
Sep 12, 2018
Merged

[PLAT-1678] Change to use new objdump command 2X #130

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b8f52a
change objdump to use new command
Pezzah Sep 7, 2018
15f5419
use more precise command
Pezzah Sep 10, 2018
99ae5ce
Update changelog
kattrali Sep 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/groovy/com/bugsnag/android/gradle/BugsnagUploadNdkTask.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ class BugsnagUploadNdkTask extends BugsnagUploadAbstractTask {
// Call objdump, redirecting output to the output file
project.logger.info("${getLogPrefix()} Calling objdump process")

ProcessBuilder builder = new ProcessBuilder(objDumpPath.toString(), "--disassemble", "--demangle", "--line-numbers", "--section=.text", sharedObject.toString())
ProcessBuilder builder = new ProcessBuilder(objDumpPath.toString(), "-W", "-x", "--section=.debug_line", sharedObject.toString())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What subset of -W is actually necessary (since it wraps several options)? This file size could be reduced if we know specifically which components are required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I have refined the command to use --dwarf=info --dwarf=rawline. In my example this has reduced the size from 72Mb -> 67Mb

builder.redirectError(errorOutputFile)
Process process = builder.start()

Expand Down Expand Up @@ -210,7 +210,7 @@ class BugsnagUploadNdkTask extends BugsnagUploadAbstractTask {
*/
void uploadSymbols(File mappingFile, String arch, String sharedObjectName) {
MultipartEntity mpEntity = new MultipartEntity()
mpEntity.addPart("soMappingFile", new FileBody(mappingFile))
mpEntity.addPart("soSymbolFile", new FileBody(mappingFile))
mpEntity.addPart("arch", new StringBody(arch))
mpEntity.addPart("sharedObjectName", new StringBody(sharedObjectName))
mpEntity.addPart("projectRoot", new StringBody(projectDir.toString()))
Expand Down