[PLAT-1678] Improve speed for NDK symbol uploads (#130)

bugsnag · Sep 12, 2018 · 2084129 · 2084129
1 parent 69cefc6
commit 2084129
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+## TBD
+
+* Reduce processing requirements to improve upload speed for NDK mapping files
+  [Dave Perryman](https://github.com/Pezzah)
+  [#130](https://github.com/bugsnag/bugsnag-android-gradle-plugin/pull/130)
+
 ## 2.5.0 (2018-08-30)
 
 * Compress Android NDK mapping files to decrease upload times

diff --git a/src/main/groovy/com/bugsnag/android/gradle/BugsnagUploadNdkTask.groovy b/src/main/groovy/com/bugsnag/android/gradle/BugsnagUploadNdkTask.groovy
@@ -152,7 +152,7 @@ class BugsnagUploadNdkTask extends BugsnagUploadAbstractTask {
                 // Call objdump, redirecting output to the output file
                 project.logger.info("${getLogPrefix()} Calling objdump process")
 
-                ProcessBuilder builder = new ProcessBuilder(objDumpPath.toString(), "--disassemble", "--demangle", "--line-numbers", "--section=.text", sharedObject.toString())
+                ProcessBuilder builder = new ProcessBuilder(objDumpPath.toString(), "--dwarf=info", "--dwarf=rawline", sharedObject.toString())
                 builder.redirectError(errorOutputFile)
                 Process process = builder.start()
 
@@ -210,7 +210,7 @@ class BugsnagUploadNdkTask extends BugsnagUploadAbstractTask {
      */
     void uploadSymbols(File mappingFile, String arch, String sharedObjectName) {
         MultipartEntity mpEntity = new MultipartEntity()
-        mpEntity.addPart("soMappingFile", new FileBody(mappingFile))
+        mpEntity.addPart("soSymbolFile", new FileBody(mappingFile))
         mpEntity.addPart("arch", new StringBody(arch))
         mpEntity.addPart("sharedObjectName", new StringBody(sharedObjectName))
         mpEntity.addPart("projectRoot", new StringBody(projectDir.toString()))