Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monorepo-symlink-test security issue #319

Closed
avosper-intellaegis opened this issue Sep 19, 2023 · 1 comment
Closed

monorepo-symlink-test security issue #319

avosper-intellaegis opened this issue Sep 19, 2023 · 1 comment

Comments

@avosper-intellaegis
Copy link

This package which is included in our project by a transitive dependency appears to include what the monorepo-symlink-test package which is identified as a malicious package in sca scanning tools such as AWS Inspector (9.8 - CRITICAL rating):

https://security.snyk.io/vuln/SNYK-JS-MONOREPOSYMLINKTEST-5865510

and has been set as NPM Security Holding package:

https://www.npmjs.com/package/monorepo-symlink-test

Other related bugs:

Unitech/pm2#5669
@avosper-intellaegis avosper-intellaegis mentioned this issue Sep 19, 2023
Open
@ljharb
Copy link
Member

ljharb commented Sep 19, 2023

Because it's a private package that just coincidentally has the same name as the malicious one, it is a false positive - so whatever tool is flagging this repo is broken, and you should strongly reconsider using a tool that is this naive about npm package names.

Duplicate of #303. Duplicate of #291. Duplicate of #288. Duplicate of #304. Duplicate of #305. Duplicate of #306. Duplicate of #309. Duplicate of #310. Duplicate of #311. Duplicate of #312. Duplicate of #314. Duplicate of #317. Duplicate of #318.

@ljharb ljharb closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2023
ljharb added a commit that referenced this issue Oct 10, 2023
@ljharb
[Tests] avoid publishing "malformed package.json" test to avoid flawe…
9e6f936 
…d security scanners

Fixes #319.
Fixes #318.
Fixes #317.
Fixes #314.
Closes #313.
Fixes #312.
Fixes #311.
Fixes #310.
Fixes #309.
Fixes #306.
Fixes #305.
Fixes #304.
Fixes #303.
Fixes #291.
Fixes #288.
ljharb added a commit that referenced this issue Oct 10, 2023
@ljharb
[Tests] rename innocent test project to avoid flawed security scanners
bce4768 
    Fixes #319.
    Fixes #318.
    Fixes #317.
    Fixes #314.
    Closes #313.
    Fixes #312.
    Fixes #311.
    Fixes #310.
    Fixes #309.
    Fixes #306.
    Fixes #305.
    Fixes #304.
    Fixes #303.
    Fixes #291.
    Fixes #288.
ljharb added a commit that referenced this issue Oct 10, 2023
@ljharb
[Tests] rename innocent test project to avoid flawed security scanners
c24f451 
    Fixes #319.
    Fixes #318.
    Fixes #317.
    Fixes #314.
    Closes #313.
    Fixes #312.
    Fixes #311.
    Fixes #310.
    Fixes #309.
    Fixes #306.
    Fixes #305.
    Fixes #304.
    Fixes #303.
    Fixes #291.
    Fixes #288.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @avosper-intellaegis