Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical Vulnerability reported on monorepo-symlink-test - False Negative #317

Closed
bzemms opened this issue Sep 18, 2023 · 1 comment
Closed

Comments

@bzemms
Copy link

bzemms commented Sep 18, 2023

Grype is reporting that this internal test
monorepo-symlink-test in https://github.com/browserify/resolve/blob/main/test/resolver/multirepo/package.json
is critical

monorepo-symlink-test  0.0.0                npm   GHSA-2jcg-qqmg-46q6  Critical

It's a false negative since is not the real pkg monorepo-symlink-test https://security.snyk.io/vuln/SNYK-JS-MONOREPOSYMLINKTEST-5865510

Can you change this name?

@ljharb
Copy link
Member

ljharb commented Sep 18, 2023

Because it's a private package that just coincidentally has the same name as the malicious one, it is a false positive - so whatever tool is flagging this repo is broken, and you should strongly reconsider using a tool that is this naive about npm package names.

Duplicate of #303. Duplicate of #291. Duplicate of #288. Duplicate of #304. Duplicate of #305. Duplicate of #306. Duplicate of #309. Duplicate of #310. Duplicate of #311. Duplicate of #312. Duplicate of #314.

I'm not going to change the name so that a poorly implemented tool can hide its failure.

@ljharb ljharb closed this as not planned Won't fix, can't repro, duplicate, stale Sep 18, 2023
ljharb added a commit that referenced this issue Oct 10, 2023
…d security scanners

Fixes #319.
Fixes #318.
Fixes #317.
Fixes #314.
Closes #313.
Fixes #312.
Fixes #311.
Fixes #310.
Fixes #309.
Fixes #306.
Fixes #305.
Fixes #304.
Fixes #303.
Fixes #291.
Fixes #288.
ljharb added a commit that referenced this issue Oct 10, 2023
    Fixes #319.
    Fixes #318.
    Fixes #317.
    Fixes #314.
    Closes #313.
    Fixes #312.
    Fixes #311.
    Fixes #310.
    Fixes #309.
    Fixes #306.
    Fixes #305.
    Fixes #304.
    Fixes #303.
    Fixes #291.
    Fixes #288.
ljharb added a commit that referenced this issue Oct 10, 2023
    Fixes #319.
    Fixes #318.
    Fixes #317.
    Fixes #314.
    Closes #313.
    Fixes #312.
    Fixes #311.
    Fixes #310.
    Fixes #309.
    Fixes #306.
    Fixes #305.
    Fixes #304.
    Fixes #303.
    Fixes #291.
    Fixes #288.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants