Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Critical vulnerability monorepo-symlink-test #311

Closed
Iuriy-Budnikov opened this issue Sep 3, 2023 · 2 comments
Closed

Critical vulnerability monorepo-symlink-test #311

Iuriy-Budnikov opened this issue Sep 3, 2023 · 2 comments

Comments

@Iuriy-Budnikov
Copy link

Iuriy-Budnikov commented Sep 3, 2023 •
edited
Loading

We are using AWS ERC scanner which doesn't support ignoring critical vulnerabilities.
I know that this is an edge case with a name matching monorepo-symlink-test.
Is it possible to rename this package name to something different? For ex browserify-symlink-test.

Thanks!
@ljharb
Copy link
Member

ljharb commented Sep 3, 2023

Nope; I’m not going to rename a false positive just because a scanning tool was naive.

Because it's a private package that just coincidentally has the same name as the malicious one, it is a false positive - so whatever tool is flagging this repo is broken, and you should strongly reconsider using a tool that is this naive about npm package names.

Duplicate of #303. Duplicate of #291. Duplicate of #288. Duplicate of #304. Duplicate of #305. Duplicate of #306. Duplicate of #309. Duplicate of #310.

@ljharb ljharb closed this as not planned Won't fix, can't repro, duplicate, stale Sep 3, 2023
@ljharb ljharb mentioned this issue Sep 4, 2023
Closed
@Iuriy-Budnikov
Copy link
Author

If someone is faced with the same issue I would recommend deleting this file before running snyk.
It should help.

rm app/node_modules/resolve/test/resolver/multirepo/package.json

@ljharb ljharb mentioned this issue Sep 8, 2023
Closed
This was referenced Sep 18, 2023
Closed
Closed
ljharb added a commit that referenced this issue Oct 10, 2023
@ljharb
[Tests] avoid publishing "malformed package.json" test to avoid flawe…
9e6f936 
…d security scanners

Fixes #319.
Fixes #318.
Fixes #317.
Fixes #314.
Closes #313.
Fixes #312.
Fixes #311.
Fixes #310.
Fixes #309.
Fixes #306.
Fixes #305.
Fixes #304.
Fixes #303.
Fixes #291.
Fixes #288.
ljharb added a commit that referenced this issue Oct 10, 2023
@ljharb
[Tests] rename innocent test project to avoid flawed security scanners
bce4768 
    Fixes #319.
    Fixes #318.
    Fixes #317.
    Fixes #314.
    Closes #313.
    Fixes #312.
    Fixes #311.
    Fixes #310.
    Fixes #309.
    Fixes #306.
    Fixes #305.
    Fixes #304.
    Fixes #303.
    Fixes #291.
    Fixes #288.
ljharb added a commit that referenced this issue Oct 10, 2023
@ljharb
[Tests] rename innocent test project to avoid flawed security scanners
c24f451 
    Fixes #319.
    Fixes #318.
    Fixes #317.
    Fixes #314.
    Closes #313.
    Fixes #312.
    Fixes #311.
    Fixes #310.
    Fixes #309.
    Fixes #306.
    Fixes #305.
    Fixes #304.
    Fixes #303.
    Fixes #291.
    Fixes #288.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @Iuriy-Budnikov