Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store & Sync LNURL info #617

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Store & Sync LNURL info #617

merged 3 commits into from
Dec 23, 2024

Conversation

dangeross
Copy link
Collaborator

@dangeross dangeross commented Dec 17, 2024

This PR:

  • Stores the LNURL-pay/withdraw info in the payment details table
  • Decrypts the AES success action data once the preimage is received
  • Syncs the payment details table for Liquid and LNURL data

Needs PR breez/breez-sdk-greenlight#1148

Fixes #318

@dangeross dangeross force-pushed the savage-lnurl-payment-details branch from 483d141 to 9c08194 Compare December 18, 2024 20:43
@dangeross dangeross marked this pull request as ready for review December 18, 2024 20:51
@dangeross dangeross changed the title Store LNURL info Store & Sync LNURL info Dec 18, 2024
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added a small comment

VALUES (?, ?, ?, ?)
ON CONFLICT (tx_id)
DO UPDATE SET
{destination_update}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we use the same coalesce statement for the destination like we do for lnurl info?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The destination is not optional in the struct, so can't be set back to null

@dangeross dangeross force-pushed the savage-lnurl-payment-details branch from 9c08194 to 6f4284a Compare December 19, 2024 17:48
Copy link
Member

@hydra-yse hydra-yse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roeierez roeierez added this to the v0.6..0 milestone Dec 23, 2024
@dangeross dangeross merged commit f4f9529 into rt-sync Dec 23, 2024
9 checks passed
@dangeross dangeross deleted the savage-lnurl-payment-details branch December 23, 2024 12:06
hydra-yse pushed a commit that referenced this pull request Dec 24, 2024
* Persist and decrypt LNURL info

* Update Notification Plugin

* Sync payment details
hydra-yse added a commit that referenced this pull request Dec 24, 2024
* feat(rt-sync): add persistency layer (#555)

* feat(rt-sync): add pull and merge (#556)

* feat(rt-sync): add push logic and run method (#568)

* feat(rt-sync): integrate rt-sync with the sdk

fix: add formatting command to build

feat: add secondary trigger to sync

deps: add tonic tls-webpki-roots

feat: prevent double claiming on status stream handlers

fix: add tx commit to chain swap update (#588)

fix: ensure we pull records before prepare_send

fix: fmt and tests

* fix: set initial pulled state to `Recoverable`

* feat(rt-sync): add `last_derivation_index` to sync service

* Single chain source

* Handle Recoverable state

* fix(rt-sync): chain recovery integration (#590)

Co-authored-by: yse <[email protected]>

* feat(rt-sync): add `pair_fees_json`

* fix(rt-sync): clean already persisted incoming records

* feat: cache wallet info (#591)

* log: add status-stream logging for non-local swaps

* Sync improvements (#598)

* Full sync on new Bitcoin block

* Track the last unconfirmed refund tx

* Trigger synced event on partial sync

* fix: remove `REPLACE` clause from swap insert/update

* fix(rt-sync): update chain swap payer/receiver amount (#604)

* Fix syncing last derivation index

* fix: update bindings and lockfile

* remove logs

* fix(rt-sync): avoid reuse of derivation index update logic (#608)

* Add 5 index buffer to full scan

* Fix storing claim_address (#609)

* Filter incoming MRH txs by swap timestamp

* fix liquid panding timestamp

* persist tx data timestamp

* Update unconfirmed transactions

* feat: add API key (#618)

* Use configured lazy connect channel in sync service

* fix: set lower-case header (#624)

* fix error message

* Store & Sync LNURL info (#617)

* Persist and decrypt LNURL info

* Update Notification Plugin

* Sync payment details

* Update list payments to include chain swaps with only user lockup (#620)

* Update payments query to include chain swaps without txs

* Allow emitting a payment event without tx_id

* fix: bindings

---------

Co-authored-by: Ross Savage <[email protected]>
Co-authored-by: Ross Savage <[email protected]>
Co-authored-by: Roei Erez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants