Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real-time Sync: Add push logic and run method #568

Merged
merged 6 commits into from
Dec 5, 2024
Merged

Conversation

hydra-yse
Copy link
Member

@hydra-yse hydra-yse commented Nov 16, 2024

Based on #555 and #556.
Closes #504, closes #505.

TODO:

  • Add unit tests

@hydra-yse hydra-yse requested a review from roeierez November 16, 2024 01:23
@hydra-yse hydra-yse self-assigned this Nov 16, 2024
lib/core/src/sync/mod.rs Outdated Show resolved Hide resolved
lib/core/src/sync/mod.rs Outdated Show resolved Hide resolved
lib/core/src/sync/mod.rs Outdated Show resolved Hide resolved
lib/core/src/sync/mod.rs Outdated Show resolved Hide resolved
lib/core/src/sync/mod.rs Outdated Show resolved Hide resolved
lib/core/src/sync/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some small comments.

lib/core/src/persist/chain.rs Show resolved Hide resolved
lib/core/src/sync/mod.rs Outdated Show resolved Hide resolved
lib/core/src/persist/receive.rs Outdated Show resolved Hide resolved
lib/core/src/sync/mod.rs Show resolved Hide resolved
Copy link
Collaborator

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK


// Clean incoming
let record = Record::new(
SyncData::Receive(new_receive_sync_data(None, None)),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SyncData::Receive(new_receive_sync_data(None, None)),
SyncData::Receive(new_receive_sync_data()),

assert_eq!(incoming_records.len(), 0); // Records have been cleaned

let mut inapplicable_record = Record::new(
SyncData::Receive(new_receive_sync_data(None, None)),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SyncData::Receive(new_receive_sync_data(None, None)),
SyncData::Receive(new_receive_sync_data()),

@hydra-yse hydra-yse changed the base branch from yse-rt-merge to rt-sync December 5, 2024 01:39
@hydra-yse hydra-yse merged commit d532ed8 into rt-sync Dec 5, 2024
hydra-yse added a commit that referenced this pull request Dec 24, 2024
* feat(rt-sync): add persistency layer (#555)

* feat(rt-sync): add pull and merge (#556)

* feat(rt-sync): add push logic and run method (#568)

* feat(rt-sync): integrate rt-sync with the sdk

fix: add formatting command to build

feat: add secondary trigger to sync

deps: add tonic tls-webpki-roots

feat: prevent double claiming on status stream handlers

fix: add tx commit to chain swap update (#588)

fix: ensure we pull records before prepare_send

fix: fmt and tests

* fix: set initial pulled state to `Recoverable`

* feat(rt-sync): add `last_derivation_index` to sync service

* Single chain source

* Handle Recoverable state

* fix(rt-sync): chain recovery integration (#590)

Co-authored-by: yse <[email protected]>

* feat(rt-sync): add `pair_fees_json`

* fix(rt-sync): clean already persisted incoming records

* feat: cache wallet info (#591)

* log: add status-stream logging for non-local swaps

* Sync improvements (#598)

* Full sync on new Bitcoin block

* Track the last unconfirmed refund tx

* Trigger synced event on partial sync

* fix: remove `REPLACE` clause from swap insert/update

* fix(rt-sync): update chain swap payer/receiver amount (#604)

* Fix syncing last derivation index

* fix: update bindings and lockfile

* remove logs

* fix(rt-sync): avoid reuse of derivation index update logic (#608)

* Add 5 index buffer to full scan

* Fix storing claim_address (#609)

* Filter incoming MRH txs by swap timestamp

* fix liquid panding timestamp

* persist tx data timestamp

* Update unconfirmed transactions

* feat: add API key (#618)

* Use configured lazy connect channel in sync service

* fix: set lower-case header (#624)

* fix error message

* Store & Sync LNURL info (#617)

* Persist and decrypt LNURL info

* Update Notification Plugin

* Sync payment details

* Update list payments to include chain swaps with only user lockup (#620)

* Update payments query to include chain swaps without txs

* Allow emitting a payment event without tx_id

* fix: bindings

---------

Co-authored-by: Ross Savage <[email protected]>
Co-authored-by: Ross Savage <[email protected]>
Co-authored-by: Roei Erez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants