Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uplift to 1.4] Don't use cached images for NTP Sponsored images #4542

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

simonhong
Copy link
Member

When assets are updated, we should display new images always.

Fix brave/brave-browser#8112

When assets are updated, we should display new images always.

Fix brave/brave-browser#8112
@simonhong simonhong requested a review from petemill as a code owner February 7, 2020 00:46
@simonhong simonhong self-assigned this Feb 7, 2020
@simonhong simonhong added this to the 1.4.x - Beta milestone Feb 7, 2020
@petemill petemill requested a review from a team February 7, 2020 04:28
@kjozwiak
Copy link
Member

kjozwiak commented Feb 7, 2020

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.4.x approved after deliberating with @brave/uplift-approvers. Failures are all related to audit-network, lint and test-intsall which are known issues and not related to this specific PR.

Please ensure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 896d950 into 1.4.x Feb 7, 2020
@kjozwiak kjozwiak deleted the uplift_4539_to_1_4 branch February 7, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants