Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 7976: Adding a proxy for Crowd Deny (uplift to 1.4.x) #4527

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

brave-builds
Copy link
Collaborator

Uplift of #4482

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Feb 6, 2020
@brave-builds brave-builds added this to the 1.4.x - Beta milestone Feb 6, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Feb 6, 2020

It doesn't seem like this even started and eventually timed out as per:

ERROR: No item named brave-browser-build-pr/pr4482_crowd_deny_proxy_1.4.x found
Finished: FAILURE

Going to restart and see if it helps 👍

@kjozwiak
Copy link
Member

kjozwiak commented Feb 6, 2020

Linux, macOS and Win x64 failed audit-network which is a known issue and not specific to this PR:

macOS failed test-install which is a known issue and not specific to this PR:

Looks like test-unit failed on Win x64 as per the following:

02:50:20  Backtrace:
02:50:20  
02:50:20  	testing::internal::AssertHelper::operator= [0x00007FF746C17154+136] (C:\.4.x\src\third_party\googletest\src\googletest\src\gtest.cc:397)
02:50:20  
02:50:20  	install_static::InstallDetailsTest_VersionMismatch_Test::TestBody [0x00007FF746BEE7BB+245] (C:\.4.x\src\brave\chromium_src\chrome\install_static\brave_install_details_unittest.cc:82)
02:50:20  
02:50:20  	testing::internal::UnitTestImpl::RunAllTests [0x00007FF746C250BE+5344] (C:\.4.x\src\third_party\googletest\src\googletest\src\gtest.cc:5338)
02:50:20  
02:50:20  
02:50:20  
02:50:20  [  FAILED  ] InstallDetailsTest.VersionMismatch (47 ms)

Going to restart Win x64

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Feb 6, 2020
@jumde jumde force-pushed the pr4482_crowd_deny_proxy_1.4.x branch from d14287a to 799bded Compare February 6, 2020 17:21
@jumde jumde removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Feb 6, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Feb 7, 2020

lint failed on the following platforms which is a known issue and not associated with this PR:

audit-network failed on the following platforms which is a known issue and not associated with this PR:

Restarting Win due to a disconnected agent as per:

17:31:25  Cannot contact i-0575f548c8408c6de: hudson.remoting.RequestAbortedException: java.io.IOException: Unexpected termination of the channel
17:36:30  Could not connect to i-0575f548c8408c6de to send interrupt signal to process

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Feb 7, 2020
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.4.x approved after deliberating with @brave/uplift-approvers. As per #4527 (comment), both lint and audit-network are failing which is a known issue and not related to this particular PR.

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit b342644 into 1.4.x Feb 7, 2020
@kjozwiak kjozwiak deleted the pr4482_crowd_deny_proxy_1.4.x branch February 7, 2020 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants