Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't cache NTP sponsored images assets #8112

Closed
simonhong opened this issue Feb 7, 2020 · 2 comments · Fixed by brave/brave-core#4539
Closed

Don't cache NTP sponsored images assets #8112

simonhong opened this issue Feb 7, 2020 · 2 comments · Fixed by brave/brave-core#4539
Assignees
@simonhong
Labels
feature/new-tab QA/No QA Pass-macOS release-notes/exclude
Milestone
1.3.x - Release

Comments

@simonhong
Copy link
Member

When assets are updated, we should provide new assets always.
@simonhong simonhong added this to the 1.6.x - Nightly milestone Feb 7, 2020
@simonhong simonhong self-assigned this Feb 7, 2020
@simonhong simonhong mentioned this issue Feb 7, 2020
Merged
32 tasks
simonhong added a commit to brave/brave-core that referenced this issue Feb 7, 2020
@simonhong
Don't use cached images for NTP Sponsored images
d7e389c 
When assets are updated, we should display new images always.

Fix brave/brave-browser#8112
simonhong added a commit to brave/brave-core that referenced this issue Feb 7, 2020
@simonhong
Don't use cached images for NTP Sponsored images
b68fad9 
When assets are updated, we should display new images always.

Fix brave/brave-browser#8112
simonhong added a commit to brave/brave-core that referenced this issue Feb 7, 2020
@simonhong
Don't use cached images for NTP Sponsored images
d4d7fd3 
When assets are updated, we should display new images always.

Fix brave/brave-browser#8112
simonhong added a commit to brave/brave-core that referenced this issue Feb 7, 2020
@simonhong
Don't use cached images for NTP Sponsored images
12cec35 
When assets are updated, we should display new images always.

Fix brave/brave-browser#8112
This was referenced Feb 7, 2020
Merged
Merged
Merged
@kjozwiak kjozwiak modified the milestones: 1.6.x - Nightly, 1.3.x - Release Feb 7, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Feb 7, 2020

Verification PASSED on macOS 10.15.3 x64 using the following build:

Brave 1.3.113 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS macOS Version 10.15.3 (Build 19D76)

Example: https://bravesoftware.slack.com/archives/CQGTGBNH1/p1581065695141200

@kjozwiak
Copy link
Member

kjozwiak commented Feb 7, 2020

Changing this to a QA/No. This is going to be hard to QA as we don't have profiles on Linux and Windows in this state. Desktop is also pointing to production which makes it more difficult. I was lucky enough to save a a profile on macOS so we could verify the above on at least one of the platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/new-tab QA/No QA Pass-macOS release-notes/exclude
Projects
None yet
Milestone
1.3.x - Release
Development

Successfully merging a pull request may close this issue.

Don't use cached images for NTP Sponsored images brave/brave-core
2 participants
@kjozwiak @simonhong