Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update brave-ui to v0.24.1 #445

Merged
merged 2 commits into from
Sep 14, 2018
Merged

Update brave-ui to v0.24.1 #445

merged 2 commits into from
Sep 14, 2018

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Sep 13, 2018 •
edited
Loading

also reverts #441 which added some deps not needed for this update

fix brave/brave-browser#1133

@cezaraugusto cezaraugusto self-assigned this Sep 13, 2018
@cezaraugusto cezaraugusto requested a review from yrliou September 13, 2018 01:57
yrliou
yrliou approved these changes Sep 14, 2018
View reviewed changes
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cezaraugusto cezaraugusto merged commit a9eaab0 into master Sep 14, 2018
@cezaraugusto cezaraugusto deleted the brave-ui-update branch September 14, 2018 22:47
cezaraugusto added a commit that referenced this pull request Sep 14, 2018
@cezaraugusto
Merge pull request #445 from brave/brave-ui-update
f0745ae 
Update brave-ui to v0.24.1
@cezaraugusto
Copy link
Contributor Author

heads-up for the release team this work is the same as #441 without the deps added in package-lock.json by npm unrelated to the code changes applied here -- thus removed.

master: a9eaab0
0.55.x f0745ae

@yrliou yrliou mentioned this pull request Sep 18, 2018
Merged
11 tasks
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
fmarier pushed a commit that referenced this pull request Oct 29, 2019
@bbondy
Merge pull request #445 from brave/pythonpath
cdb4431 
Fixes issue #444, add vendored path to Python requests module
petemill pushed a commit that referenced this pull request Jul 27, 2020
@bbondy
Merge pull request #445 from brave/pythonpath
ec50aa4 
Fixes issue #444, add vendored path to Python requests module
petemill pushed a commit that referenced this pull request Jul 28, 2020
@bbondy
Merge pull request #445 from brave/pythonpath
2907b36 
Fixes issue #444, add vendored path to Python requests module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrliou yrliou yrliou approved these changes

Assignees

@cezaraugusto cezaraugusto

Labels
dependency/brave-ui
Projects
None yet
Milestone
0.55.x - Release
Development

Successfully merging this pull request may close these issues.

Update brave-ui to v0.24.1
3 participants
@cezaraugusto @yrliou @bbondy