Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make user data dir independent to BRANDING file on MacOS #444

Merged
merged 1 commit into from
Sep 13, 2018
Merged

Make user data dir independent to BRANDING file on MacOS #444

merged 1 commit into from
Sep 13, 2018

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Sep 13, 2018 •
edited
Loading

User data should be always brave-browser-xxx format.
This is prerequisite for #437

close brave/brave-browser#1106

It's hard to add test for this because user dir is set to Information Property List that test doesn't have.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@simonhong
Make user data dir independent to BRANDING file
1bc9a22 
User data should be always brave-browser-xxx format.
@simonhong simonhong self-assigned this Sep 13, 2018
@simonhong simonhong requested a review from bbondy September 13, 2018 01:09
@simonhong simonhong changed the title Make user data dir independent to BRANDING file Make user data dir independent to BRANDING file on MacOS Sep 13, 2018
@bbondy bbondy merged commit c4cceb7 into master Sep 13, 2018
bbondy added a commit that referenced this pull request Sep 13, 2018
@bbondy
Merge pull request #444 from brave/user_dir_on_mac
67dc9e8 
Make user data dir independent to BRANDING file on MacOS
@bbondy
Copy link
Member

bbondy commented Sep 13, 2018

master c4cceb7
0.55.x 67dc9e8

@simonhong simonhong deleted the user_dir_on_mac branch September 15, 2018 22:17
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
fmarier pushed a commit that referenced this pull request Oct 29, 2019
@mbacchi
Fixes issue #444, add vendored path to requests
f6fa123
fmarier pushed a commit that referenced this pull request Oct 29, 2019
@bbondy
Merge pull request #445 from brave/pythonpath
cdb4431 
Fixes issue #444, add vendored path to Python requests module
petemill pushed a commit that referenced this pull request Jul 27, 2020
@mbacchi
Fixes issue #444, add vendored path to requests
154330b
petemill pushed a commit that referenced this pull request Jul 27, 2020
@bbondy
Merge pull request #445 from brave/pythonpath
ec50aa4 
Fixes issue #444, add vendored path to Python requests module
petemill pushed a commit that referenced this pull request Jul 28, 2020
@mbacchi
Fixes issue #444, add vendored path to requests
e631d04
petemill pushed a commit that referenced this pull request Jul 28, 2020
@bbondy
Merge pull request #445 from brave/pythonpath
2907b36 
Fixes issue #444, add vendored path to Python requests module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
0.55.x - Release
Development

Successfully merging this pull request may close these issues.

Make user data dir independent with BRANDING
2 participants
@simonhong @bbondy