Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumping brave-ui to 0.24.1 #441

Merged
merged 1 commit into from
Sep 12, 2018
Merged

Bumping brave-ui to 0.24.1 #441

merged 1 commit into from
Sep 12, 2018

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Sep 12, 2018

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@ryanml ryanml self-assigned this Sep 12, 2018
@cezaraugusto cezaraugusto merged commit bd2a700 into brave:master Sep 12, 2018
@ryanml ryanml mentioned this pull request Sep 12, 2018
Closed
cezaraugusto added a commit that referenced this pull request Sep 13, 2018
@cezaraugusto
Revert "Merge pull request #441 from ryanml/brave-ui-0.24.1"
4221022 
This reverts commit bd2a700, reversing
changes made to 1725bec.
@cezaraugusto cezaraugusto mentioned this pull request Sep 13, 2018
Merged
@bbondy
Copy link
Member

bbondy commented Sep 13, 2018

@cezaraugusto can you label accordingly and add a version label? Thanks!

cezaraugusto added a commit that referenced this pull request Sep 13, 2018
@cezaraugusto
Merge pull request #441 from ryanml/brave-ui-0.24.1
1c0ea60 
Bumping brave-ui to 0.24.1
@cezaraugusto
Copy link
Contributor

master (0.56.x): bd2a700
0.55.x 1c0ea60

@cezaraugusto cezaraugusto mentioned this pull request Sep 14, 2018
Closed
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
fmarier pushed a commit that referenced this pull request Oct 29, 2019
@bbondy
Merge pull request #441 from brave/copy_midl_only_on_windows
33d610e 
Copy midl files only on Windows
petemill pushed a commit that referenced this pull request Jul 27, 2020
@bbondy
Merge pull request #441 from brave/copy_midl_only_on_windows
534c399 
Copy midl files only on Windows
petemill pushed a commit that referenced this pull request Jul 28, 2020
@bbondy
Merge pull request #441 from brave/copy_midl_only_on_windows
a031f82 
Copy midl files only on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cezaraugusto cezaraugusto cezaraugusto approved these changes

@jasonrsadler jasonrsadler Awaiting requested review from jasonrsadler

Assignees

@ryanml ryanml

Labels
dependency/brave-ui
Projects
None yet
Milestone
0.55.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanml @bbondy @cezaraugusto