Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes next payment date appearing as 4th instead of 5th for a user in Australia on Android #4176

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Dec 9, 2019

Fixes brave/brave-browser#7218
Requires #4205

Submitter Checklist:

Test Plan:

Confirm "Next payment date" is correct for different timezones around the world

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc
Copy link
Contributor

Can you please add unit test for it? Thank you

@tmancey tmancey added the CI/skip Do not run CI builds (except noplatform) label Dec 10, 2019
@tmancey tmancey force-pushed the issues/7218 branch 3 times, most recently from 8e0f06c to cee4d98 Compare December 10, 2019 10:37
@tmancey tmancey removed the CI/skip Do not run CI builds (except noplatform) label Dec 10, 2019
@tmancey
Copy link
Collaborator Author

tmancey commented Dec 10, 2019

@NejcZdovc Updated code and unit tests to use UTC and not Local time. As local time should only be used when displaying the time in UI

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@tmancey tmancey merged commit a04176a into master Dec 10, 2019
@tmancey tmancey deleted the issues/7218 branch December 10, 2019 17:36
@tmancey
Copy link
Collaborator Author

tmancey commented Dec 10, 2019

Discussed with @mihaiplesa and unrelated CI failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next payment date appearing as 4th instead of 5th for a user in Australia
5 participants