Next payment date appearing as 4th instead of 5th for a user in Australia

[tmancey]

Description

Next payment date appearing as 4th instead of 5th for a user in Australia

Steps to Reproduce

1. Change timezone on the device to GMT+11:00 (i.e. Lord Howe Daylight Time)
2. Change time on the device to 01:00

Actual result:

Next payment date of 4th

Expected result:

Next payment date of 6th (as we payout on the 5th of each month based upon the UTC timezone)

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the dev channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

[tmancey]

The next payment dates are based on a UTC timestamp, therefore as the above time zone is 11 hours ahead the next payment date should be the 6th

[mandar-brave]

My preference and as spec, should be using local time @tmancey; considering Rewards uses local time, it makes sense to follow that.

[tmancey]

@mandar-brave We are using local time, which is working as expected on macOS and iOS. I am going to change the way we format the date and retest on Android (only difference I see with this particular date is we use FromString which should be using local time). I will refactor the code to not use FromString as we do not use this call elsewhere

[GeetaSarvadnya]

Verification passed on

Brave	1.4.86 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision	449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified the test plan from Fixes next payment date appearing as 4th instead of 5th for a user in Australia on Android brave-core#4176

Australia, India and Central European Standard Time

Central US and Canada Time Zone:

Verification PASSED on macOS 10.15.3 x64 using the following build:

Brave	1.4.93 Chromium: 80.0.3987.116 (Official Build) (64-bit)
Revision	dc00a510e4c2ae25c4d084cc3d946fc782249224-refs/branch-heads/3987@{#917}
OS	macOS Version 10.15.3 (Build 19D76)

Bengaluru - India, Sydney - Australia:

New York, NY - United States, Chicago, IL - United States, Whitehorse - Canada:

Verification passed on

Brave	1.4.93 Chromium: 80.0.3987.116 (Official Build) (64-bit)
Revision	dc00a510e4c2ae25c4d084cc3d946fc782249224-refs/branch-heads/3987@{#917}
OS	Linux

• Verified the test plan from Fixes next payment date appearing as 4th instead of 5th for a user in Australia on Android brave-core#4176

Australia-Sydney, Indian-Christmas

America-Tell city, Africa-Bamako