Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing unit tests caused by issues/7308 #4205

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Fix failing unit tests caused by issues/7308 #4205

merged 1 commit into from
Dec 10, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Dec 10, 2019

Fixes brave/brave-browser#7308
Requires #4176

Submitter Checklist:

Test Plan:

N/A

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsclifton
Copy link
Member

Looks like CI passed on all platforms except iOS; iOS was hung indefinitely. Killed CI process and will merge as master is broken

@bsclifton bsclifton merged commit 467a894 into master Dec 10, 2019
@bsclifton bsclifton deleted the issues/7308 branch December 10, 2019 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix failing unit tests caused by https://github.com/brave/brave-browser/issues/7218
4 participants