Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checks for unused keys in Transaction deserialization (uplift to 0.71.x) #3937

Merged

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 8, 2019

Uplift of #3917
Fixes brave/brave-browser#6745

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@kjozwiak
Copy link
Member

kjozwiak commented Nov 9, 2019

Restarting macOS due to https://ci.brave.com/job/brave-browser-build-pr/job/pr3917_issue-6745-transactions-reset-after-restart_0.71.x/1/execution/node/580/log/.

Restarting Win x64 due to the following failure as per https://ci.brave.com/job/brave-browser-build-pr/job/pr3917_issue-6745-transactions-reset-after-restart_0.71.x/1/execution/node/357/log/:

15:13:49  Retrying 1 test (retry #0)
15:13:49  [ RUN      ] InstallDetailsTest.VersionMismatch
15:13:49  
15:13:49  ../../brave/chromium_src/chrome/install_static/brave_install_details_unittest.cc(82): error: Value of: FakeInstallDetails().VersionMismatch()
15:13:49  
15:13:49    Actual: true
15:13:49  
15:13:49  Expected: false
15:13:49  
15:13:49  Stack trace:
15:13:49  
15:13:49  Backtrace:
15:13:49  
15:13:49  	testing::internal::AssertHelper::operator= [0x00007FF6D9E87DEC+136] (C:\71.x\src\third_party\googletest\src\googletest\src\gtest.cc:404)
15:13:49  
15:13:49  	install_static::InstallDetailsTest_VersionMismatch_Test::TestBody [0x00007FF6D9E5F4FB+245] (C:\71.x\src\brave\chromium_src\chrome\install_static\brave_install_details_unittest.cc:82)
15:13:49  
15:13:49  
15:13:49  
15:13:49  [  FAILED  ] InstallDetailsTest.VersionMismatch (38 ms)
15:13:49  
15:13:49  [195/195] InstallDetailsTest.VersionMismatch (38 ms)
15:13:49  1 test failed:
15:13:49      InstallDetailsTest.VersionMismatch (../../brave/chromium_src/chrome/install_static/brave_install_details_unittest.cc:80)
15:13:49  Tests took 0 seconds.
15:13:49  null
15:13:49  powershell.exe : null
15:13:49  At C:\71.x@tmp\durable-45b263e6\powershellWrapper.ps1:3 char:1
15:13:49  + & powershell -NoProfile -NonInteractive -ExecutionPolicy Bypass -Comm ...
15:13:49  + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
15:13:49      + CategoryInfo          : NotSpecified: (null:String) [], RemoteException
15:13:49      + FullyQualifiedErrorId : NativeCommandError

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Nov 9, 2019
@bsclifton
Copy link
Member

bsclifton commented Nov 9, 2019

@bsclifton bsclifton added the CI/skip-macos-x64 Do not run CI builds for macOS x64 label Nov 9, 2019
@bsclifton bsclifton requested review from a team and removed request for bbondy, kjozwiak, bsclifton, rebron, NejcZdovc and srirambv November 9, 2019 05:53
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 7e5f3c6 into 0.71.x Nov 9, 2019
@bsclifton bsclifton deleted the pr3917_issue-6745-transactions-reset-after-restart_0.71.x branch November 9, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants