Transactions are reset after restart

[NejcZdovc]

Description

Steps to Reproduce

1. claim promotion
2. tip 3 times 5 BAT to verified publisher
3. wait for transaction to be completely processed
4. open ledger_state
5. make sure that transaction data is in there
6. restart browser
7. open ledger_sate

Actual result:

Transaction object is empty

"transactions": [
    {
      "viewingId": "",
      "surveyorId": "",
      "rates": {},
      "contribution_probi": "",
      "submissionStamp": "",
      "anonizeViewingId": "",
      "registrarVK": "",
      "masterUserToken": "",
      "surveyorIds": [],
      "votes": 0,
      "ballots": []
    }
  ],

Expected result:

Transaction object should persist after restart

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the dev channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

[jhoneycutt]

brave/brave-core@0177ac5 removed some unused values from being read from/written to ledger_state, but it did not remove the code that checked for them in TRANSACTION_ST::loadFromJson.

[NejcZdovc]

as @jhoneycutt said it regressed with #5917 which landed in 0.71

[LaurenWags]

Verified passed with

Brave	0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	macOS Version 10.13.6 (Build 17G5019)

• Verified test plan from Remove checks for unused keys in Transaction deserialization brave-core#3917
• Verified STR from description
• Also verified after each time Ballots may be assigned an incorrect proof #6607 was tested in Ballots may be assigned an incorrect proof #6607 (comment)

---

Verification passed on

Brave	0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	Windows 10 OS Version 1903 (Build 18362.418)

• Verified steps from issue description
• Verified transactions object is not empty after a successful transaction
• Verified ledger_state file from Ballots may be assigned an incorrect proof #6607 (comment) and transaction object was not empty

Verification passed on

Brave	0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	Ubuntu 18.04 LTS

• Verified steps from issue description
• Verified transactions object is not empty after a successful transaction
• Verified ledger_state file from Ballots may be assigned an incorrect proof #6607 (comment) and transaction object was not empty