Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checks for unused keys in Transaction deserialization #3917

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

jhoneycutt
Copy link

@jhoneycutt jhoneycutt commented Nov 7, 2019

Resolves brave/brave-browser#6745: Transactions are reset after restart.

Submitter Checklist:

Test Plan:

  • enable rewards
  • claim grant
  • do one time tip
  • wait for it to finish completely
  • open ledger_state and make sure that transaction data in in there
  • restart browser
  • open ledger_state
  • make sure that all transaction data is still there

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@jhoneycutt jhoneycutt added this to the 0.74.x - Nightly milestone Nov 7, 2019
@jhoneycutt jhoneycutt requested a review from a team November 7, 2019 20:59
@jhoneycutt jhoneycutt requested a review from NejcZdovc as a code owner November 7, 2019 20:59
@jhoneycutt jhoneycutt self-assigned this Nov 7, 2019
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Resolves #6745: Transactions are reset after restart.
@jhoneycutt jhoneycutt force-pushed the issue-6745-transactions-reset-after-restart branch from f2ac4d5 to 1f06298 Compare November 7, 2019 22:46
@bsclifton bsclifton added CI/skip-windows CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS labels Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transactions are reset after restart
4 participants