Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds contribution queue (uplift to 0.71.x) #3740

Merged
merged 3 commits into from
Oct 22, 2019
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Oct 18, 2019

Uplift of #3630 (this is needed as DB was updated here so we need to keep the same track for db versioning)
Uplift of #3658
Uplift of #3716

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@NejcZdovc NejcZdovc added feature/rewards CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-ios Do not run CI builds for iOS labels Oct 18, 2019
@NejcZdovc NejcZdovc added this to the 0.71.x - Beta milestone Oct 18, 2019
@NejcZdovc NejcZdovc self-assigned this Oct 18, 2019
@NejcZdovc NejcZdovc force-pushed the recurring-tips-71 branch 2 times, most recently from 448e65c to 13299e7 Compare October 18, 2019 11:52
@NejcZdovc NejcZdovc force-pushed the recurring-tips-71 branch 6 times, most recently from ffbe5b3 to b86ba64 Compare October 19, 2019 06:51
@NejcZdovc NejcZdovc removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Oct 19, 2019
@NejcZdovc NejcZdovc requested a review from a team October 19, 2019 14:44
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.71.x approved after deliberating with @brave/uplift-approvers. Looks like both CI/Jenkins and CI/Travis passed without any issues. @LaurenWags also spent some time QAing/making sure the PR works as per #3658 (comment).

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@NejcZdovc NejcZdovc merged commit 1a1470e into 0.71.x Oct 22, 2019
@NejcZdovc NejcZdovc deleted the recurring-tips-71 branch October 22, 2019 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants