-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored and migrated Rewards category from category to type #3630
Conversation
components/brave_rewards/browser/database/publisher_info_database.cc
Outdated
Show resolved
Hide resolved
components/brave_rewards/browser/database/publisher_info_database.cc
Outdated
Show resolved
Hide resolved
components/brave_rewards/browser/database/publisher_info_database.cc
Outdated
Show resolved
Hide resolved
aea1d73
to
0bec0fb
Compare
components/brave_rewards/browser/database/publisher_info_database.cc
Outdated
Show resolved
Hide resolved
components/brave_rewards/browser/database/publisher_info_database.cc
Outdated
Show resolved
Hide resolved
components/brave_rewards/browser/database/publisher_info_database.cc
Outdated
Show resolved
Hide resolved
components/brave_rewards/browser/database/publisher_info_database.cc
Outdated
Show resolved
Hide resolved
const auto comma_separated_from_columns = base::JoinString(from_columns, ","); | ||
const auto comma_separated_to_columns = base::JoinString(to_columns, ","); | ||
|
||
return base::StringPrintf("INSERT INTO %s (%s) SELECT %s FROM %s;", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I would place every param in separate line as it's easier to read for me. Like this
return base::StringPrintf("INSERT INTO %s (%s) SELECT %s FROM %s;",
to.c_str(),
comma_separated_to_columns.c_str(),
comma_separated_from_columns.c_str(),
from.c_str());
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
components/brave_rewards/resources/extension/brave_rewards/background/events/rewardsEvents.ts
line 101 (category -> type) -
components/brave_rewards/resources/page/brave_rewards_page.tsx
line 205 (category -> type) -
components/definitions/chromel.d.ts
line 128 (category -> type) -
components/definitions/rewards.d.ts
line 193 (category -> type) andCategory
toRewardsType
.Category
can be deleted -
please add migration tests like we had them for previous version. This way we know that db files and structure is correct
c2aaff8
to
1e62a40
Compare
3a1353e
to
a12f513
Compare
Fixes brave/brave-browser#6350
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.