Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label changes for Auto Contribute - follow up to 6228 #6483

Closed
LaurenWags opened this issue Oct 15, 2019 · 1 comment · Fixed by brave/brave-core#3716
Closed

label changes for Auto Contribute - follow up to 6228 #6483

LaurenWags opened this issue Oct 15, 2019 · 1 comment · Fixed by brave/brave-core#3716

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Oct 15, 2019

Description

Found while testing #6228 against the spec.

Some label changes still need to be made:

  1. On brave://rewards in AC panel, change the label on the third line from “Supported Sites” to “Sites viewed” (per spec).
  2. On brave://rewards in AC panel click 'Show All', change left tab label from “Supported Sites (2)” to “Sites Viewed (2)” (per spec). For this, Viewed needs to be capitalized for consistency with label on the right.

Additionally, the following label change was made per spec but should be updated:
3. On brave://rewards in AC panel, open settings. Change “Only show verified sites in Auto-Contribute list” to "Show non-verified sites in list". Text update confirmed with @davidtemkin .

Off-spec:
4. On brave://rewards in AC panel, open settings. Change "What should be allowed?" to "Other settings"

Actual result:

For 1
Screen Shot 2019-10-15 at 2 11 57 PM

For 2
Screen Shot 2019-10-15 at 2 11 45 PM

For 3
Screen Shot 2019-10-15 at 2 14 21 PM

For 4
Screen Shot 2019-10-15 at 3 25 20 PM

Expected result:

Labels to be updated.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.72.102 Chromium: 78.0.3904.50 (Official Build) nightly (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the dev channel? n/a
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @NejcZdovc @rebron @kjozwiak

@LaurenWags
Copy link
Member Author

LaurenWags commented Oct 22, 2019

Verified passed with

Brave 0.70.120 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified label changes as noted in description
    Supported sites --> Sites viewed

Screen Shot 2019-10-22 at 10 19 25 AM

Sites viewed --> Sites Viewed
Screen Shot 2019-10-22 at 10 16 39 AM

Only show verified sites in Auto-Contribute list --> Show non-verified sites in list
What should be allowed? --> Other settings
Screen Shot 2019-10-22 at 10 19 40 AM

Verification passed on

Brave 0.70.120 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified label changes as noted in the description

Supported sites --> Sites viewed

image

Sites viewed --> Sites Viewed
image

Only show verified sites in Auto-Contribute list --> Show non-verified sites in list
What should be allowed? --> Other settings

image

Verification passed on

Brave 0.70.120 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Ubuntu 18.04 LTS
  • Verified label changes as noted in description
    Supported sites --> Sites viewed
    image

Sites viewed --> Sites Viewed
image

Only show verified sites in Auto-Contribute list --> Show non-verified sites in list
What should be allowed? --> Other settings

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment