Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet): Confirm Hardware Wallet Transaction (uplift to 1.39.x) #13234

Merged
merged 3 commits into from
May 12, 2022
Merged

fix(wallet): Confirm Hardware Wallet Transaction (uplift to 1.39.x) #13234

merged 3 commits into from
May 12, 2022

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented May 2, 2022 •
edited by Douglashdaniel
Loading

Uplift of #13232
Uplift of #13263
Uplift of #13270
Resolves brave/brave-browser#22652
Resolves brave/brave-browser#22682
Resolves brave/brave-browser#22759

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team May 2, 2022 22:12
@brave-builds brave-builds self-assigned this May 2, 2022
@brave-builds brave-builds added this to the 1.39.x - Beta milestone May 2, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label May 2, 2022
@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel force-pushed the pr13232_fix-confirm-hardware-wallet-transaction_1.39.x branch from 0d54ec1 to fbc8745 Compare May 12, 2022 02:14
@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

kjozwiak
kjozwiak approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.39.x approved. QA has verified the PR on Nightly as per #13232 (comment) & #13263 (comment).

@kjozwiak kjozwiak merged commit 17dbc19 into 1.39.x May 12, 2022
@kjozwiak kjozwiak deleted the pr13232_fix-confirm-hardware-wallet-transaction_1.39.x branch May 12, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.39.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @brave-browser-releases @Douglashdaniel