Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer getting a " Complete transaction on hardware device" modal when using a Ledger #22652

Closed
bbondy opened this issue May 2, 2022 · 1 comment · Fixed by brave/brave-core#13232
Closed

No longer getting a " Complete transaction on hardware device" modal when using a Ledger #22652

bbondy opened this issue May 2, 2022 · 1 comment · Fixed by brave/brave-core#13232
Assignees
@Douglashdaniel
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.38.x - Release #6

Comments

@bbondy
Copy link
Member

bbondy commented May 2, 2022

Did Ledger and Trezor support regress?
https://community.brave.com/t/no-longer-getting-a-complete-transaction-on-hardware-device-modal-when-using-a-ledger/384267/2
@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels May 2, 2022
@bbondy bbondy added this to Web3 May 2, 2022
@Douglashdaniel Douglashdaniel self-assigned this May 2, 2022
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 May 2, 2022
@Douglashdaniel Douglashdaniel mentioned this issue May 2, 2022
Merged
24 tasks
@Douglashdaniel Douglashdaniel added this to the 1.40.x - Nightly milestone May 2, 2022
Repository owner moved this from In Progress to Done in Web3 May 2, 2022
This was referenced May 2, 2022
Merged
Merged
@srirambv
Copy link
Contributor

srirambv commented May 16, 2022 •
edited
Loading

Brave 1.38.118 Chromium: 101.0.4951.67 (Official Build) (64-bit)
Revision 8888ee7a24e2c36661ddb9536c35b7d4852a3a98-refs/branch-heads/4951@{#1230
OS ☑️ Linux ☑️ Windows 11 Version 22H2
(Build 22598.200) 		☑️ macOS Version 12.0.1
(Build 21C52)
22652-Linux.mp4
22652-Windows.mov
22652-macOS.mov

@LaurenWags LaurenWags mentioned this issue May 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.38.x - Release #6
Development

Successfully merging a pull request may close this issue.

fix(wallet): Confirm Hardware Wallet Transaction brave/brave-core
4 participants
@bbondy @kjozwiak @srirambv @Douglashdaniel