fix(wallet): Transaction Details Panel Dismissal #13270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CI/storybook-url
|
A Storybook has been deployed to preview UI for the latest push |
| @@ -291,6 +292,7 @@ handler.on(PanelActions.approveHardwareTransaction.getType(), async (store: Stor | |||
| refreshTransactionHistory(txInfo.fromAddress) | |||
| await store.dispatch(PanelActions.setSelectedTransaction(txInfo)) | |||
| await store.dispatch(PanelActions.navigateTo('transactionDetails')) | |||
| apiProxy.panelHandler.setCloseOnDeactivate(true) | |||
There was a problem hiding this comment.
Is this handler defined twice?
There was a problem hiding this comment.
const apiProxy = getWalletPanelApiProxy() is defined once
apiProxy.panelHandler.setCloseOnDeactivate(true) is called in for 2 separate instances
once for Ledger success and once for Trezor success
| if (selectedPendingTransaction) { | ||
| onConfirmTransaction() | ||
| } | ||
| const onSelectTransaction = (transaction: BraveWallet.TransactionInfo) => { |
There was a problem hiding this comment.
Did anything change in this file other than moving the function declaration order?
There was a problem hiding this comment.
Just function declaration order
muliswilliam
approved these changes
May 10, 2022
7 tasks
7 tasks
Douglashdaniel
added a commit
that referenced
this pull request
May 12, 2022
…smissal fix(wallet): Transaction Details Panel Dismissal
Douglashdaniel
added a commit
that referenced
this pull request
May 12, 2022
…smissal fix(wallet): Transaction Details Panel Dismissal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug where the
Transaction Detailspanel was not dismissing on click after completing a Hardware Wallet transaction.Resolves brave/brave-browser#22759
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Before:
Screen.Recording.2022-05-09.at.6.55.00.PM.mov
After:
Screen.Recording.2022-05-09.at.6.51.17.PM.mov