Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Chromimum to 70.0.3538.54 #1534

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Upgrade Chromimum to 70.0.3538.54 #1534

merged 1 commit into from
Oct 11, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Oct 11, 2018

Fix #1522

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@bbondy bbondy self-assigned this Oct 11, 2018
@bbondy bbondy requested a review from emerick October 11, 2018 20:13
emerick
emerick approved these changes Oct 11, 2018
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbondy bbondy merged commit a1a347c into master Oct 11, 2018
bbondy added a commit that referenced this pull request Oct 11, 2018
@bbondy
Merge pull request #1534 from brave/70.0.3538.54
18c2b6d 
Upgrade Chromimum to 70.0.3538.54
bbondy added a commit that referenced this pull request Oct 11, 2018
@bbondy
Merge pull request #1534 from brave/70.0.3538.54
4fea34a 
Upgrade Chromimum to 70.0.3538.54
@bbondy
Copy link
Member Author

bbondy commented Oct 11, 2018

master: a1a347c
0.56.x: 18c2b6d
0.55.x: 4fea34a

@bbondy bbondy added this to the 0.55.x milestone Oct 11, 2018
@bbondy bbondy removed this from the 0.55.x milestone Oct 12, 2018
@bbondy bbondy deleted the 70.0.3538.54 branch October 14, 2018 14:40
@bbondy bbondy removed the 0.55.x label Jan 14, 2019
This was referenced Mar 15, 2021
Closed
Closed
Closed
Closed
@stephendonner stephendonner mentioned this pull request Mar 15, 2021
Closed
52 tasks
@btlechowski btlechowski mentioned this pull request Mar 15, 2021
Closed
This was referenced Mar 15, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
@Plasma Plasma mentioned this pull request Mar 17, 2021
Open
@btlechowski btlechowski mentioned this pull request Mar 22, 2021
Closed
This was referenced Mar 22, 2021
Closed
Closed
This was referenced Mar 22, 2021
Closed
Closed
Closed
Closed
This was referenced Mar 22, 2021
Closed
Closed
Closed
Closed
Closed
@bsclifton bsclifton mentioned this pull request Mar 23, 2021
Closed
@JJCUBER JJCUBER mentioned this pull request Mar 23, 2021
Open
@JProof JProof mentioned this pull request Mar 23, 2021
Closed
@anmdotdev anmdotdev mentioned this pull request Mar 23, 2021
Closed
@stephendonner stephendonner mentioned this pull request Mar 23, 2021
Closed
@rebron rebron mentioned this pull request Mar 23, 2021
Closed
This was referenced Mar 23, 2021
Closed
Closed
@KarlVogel KarlVogel mentioned this pull request Mar 24, 2021
Closed
@youssef20031 youssef20031 mentioned this pull request Mar 24, 2021
Closed
@iam-cult iam-cult mentioned this pull request Mar 24, 2021
Closed
This was referenced Mar 25, 2021
Open
Open
Open
@doctord919 doctord919 mentioned this pull request Mar 25, 2021
Closed
@cjwijtmans cjwijtmans mentioned this pull request Mar 25, 2021
Open
@btlechowski btlechowski mentioned this pull request Mar 26, 2021
Closed
8 tasks
@stephendonner stephendonner mentioned this pull request Mar 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick approved these changes

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging this pull request may close these issues.
2 participants
@bbondy @emerick